Bug 1804638: add tooltip to devconsole monitoring graph #4363

vikram-raj · 2020-02-19T10:21:46Z

Fixes:
https://issues.redhat.com/browse/ODC-3099
Analysis / Root cause:
Redux were not get updated with query. So that tooltip component is not able get the query and label.
Solution Description:
Added query to redux.
Screen shots / Gifs for design review:

Browser conformance:

Chrome
Firefox
Safari
Edge

vikram-raj · 2020-02-19T10:26:17Z

/retitle Bug 1804638: add tooltip to devconsole monitoring graph

openshift-ci-robot · 2020-02-19T10:26:21Z

@vikram-raj: This pull request references Bugzilla bug 1804638, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1804638: add tooltip to devconsole monitoring graph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikram-raj · 2020-02-19T10:27:57Z

/bugzilla refresh

openshift-ci-robot · 2020-02-19T10:28:05Z

@vikram-raj: This pull request references Bugzilla bug 1804638, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai · 2020-02-19T11:32:25Z

/kind bug

invincibleJai · 2020-02-19T11:33:22Z

frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardGraph.tsx

can we have type here as well?

Added type.

christianvogt · 2020-02-20T03:05:35Z

frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardGraph.tsx

This seems very odd to me that every graph is using the same index.

@kyoto can you please provide insight into the proper usage.

Always using the index 0 looks wrong to me, so I'm not sure why this appears to be working.

For the admin perspective, I used onMouseEnter as a workaround for the problem (see #4060).

The root problem is that the tooltips assume the query is in Redux, which is actually only true for the Metrics page. Longer term, we should aim to fix that in the tooltips and remove these workarounds.

Thanks @kyoto
Longer term we will move to share more of the dashboards.

invincibleJai · 2020-02-24T14:58:28Z

/lgtm

verified locally, seems to work as expected

christianvogt · 2020-02-24T23:14:29Z

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringMetrics.tsx

 import { requirePrometheus } from '@console/internal/components/graphs';
 import { topWorkloadMetricsQueries } from '../queries';
-import MonitoringDashboardGraph from '../dashboard/MonitoringDashboardGraph';
+import ConnectedMonitoringDashboardGraph from '../dashboard/MonitoringDashboardGraph';


There's no need to change all these from MonitoringDashboardGraph to ConnectedMonitoringDashboardGraph. Infact you shouldn't care. You should use the default import as is.

I suggest changing all these import name changes back to simply MonitoringDashboardGraph

Ok so you'll need to change the name because of the eslint rule for using the same name as an exported value.

christianvogt · 2020-02-25T03:15:41Z

/approve

openshift-ci-robot · 2020-02-25T03:16:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-02-25T05:00:42Z

@vikram-raj: All pull requests linked via external trackers have merged. Bugzilla bug 1804638 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1804638: add tooltip to devconsole monitoring graph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikram-raj · 2020-02-25T06:02:01Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-02-25T06:02:09Z

@vikram-raj: new pull request created: #4455

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 19, 2020

openshift-ci-robot requested review from abhinandan13jan and nemesis09 February 19, 2020 10:22

openshift-ci-robot added the component/dev-console Related to dev-console label Feb 19, 2020

openshift-ci-robot changed the title ~~add tooltip to devconsole monitoring graph~~ Bug 1804638: add tooltip to devconsole monitoring graph Feb 19, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 19, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 19, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 19, 2020

vikram-raj force-pushed the odc-3099 branch from 981f47b to 561d12c Compare February 19, 2020 11:29

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 19, 2020

invincibleJai reviewed Feb 19, 2020

View reviewed changes

vikram-raj force-pushed the odc-3099 branch from 561d12c to dfa38fa Compare February 19, 2020 11:50

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2020

vikram-raj force-pushed the odc-3099 branch 2 times, most recently from ecf3664 to 9cc357a Compare February 19, 2020 13:53

christianvogt reviewed Feb 20, 2020

View reviewed changes

add tooltip to devconsole monitoring graph

c1270d6

vikram-raj force-pushed the odc-3099 branch from 9cc357a to c1270d6 Compare February 24, 2020 06:41

openshift-ci-robot assigned invincibleJai Feb 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020

christianvogt suggested changes Feb 24, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020

openshift-merge-robot merged commit ff06fbf into openshift:master Feb 25, 2020

vikram-raj deleted the odc-3099 branch February 25, 2020 06:01

openshift-cherrypick-robot mentioned this pull request Feb 25, 2020

[release-4.4] Bug 1806829: add tooltip to devconsole monitoring graph #4455

Merged

spadgett added this to the v4.5 milestone Feb 28, 2020

Bug 1804638: add tooltip to devconsole monitoring graph #4363

Bug 1804638: add tooltip to devconsole monitoring graph #4363

Uh oh!

Conversation

vikram-raj commented Feb 19, 2020

Uh oh!

vikram-raj commented Feb 19, 2020

Uh oh!

openshift-ci-robot commented Feb 19, 2020

Uh oh!

vikram-raj commented Feb 19, 2020

Uh oh!

openshift-ci-robot commented Feb 19, 2020

Uh oh!

invincibleJai commented Feb 19, 2020

Uh oh!

invincibleJai Feb 19, 2020

Choose a reason for hiding this comment

Uh oh!

vikram-raj Feb 19, 2020

Choose a reason for hiding this comment

Uh oh!

christianvogt Feb 20, 2020

Choose a reason for hiding this comment

Uh oh!

kyoto Feb 20, 2020

Choose a reason for hiding this comment

Uh oh!

christianvogt Feb 20, 2020

Choose a reason for hiding this comment

Uh oh!

invincibleJai commented Feb 24, 2020

Uh oh!

christianvogt Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

christianvogt Feb 25, 2020

Choose a reason for hiding this comment

Uh oh!

christianvogt commented Feb 25, 2020

Uh oh!

openshift-ci-robot commented Feb 25, 2020

Uh oh!

openshift-ci-robot commented Feb 25, 2020

Uh oh!

vikram-raj commented Feb 25, 2020

Uh oh!

openshift-cherrypick-robot commented Feb 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants