Skip to content

[release-4.4] Bug 1806829: add tooltip to devconsole monitoring graph #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 26, 2020
Merged

[release-4.4] Bug 1806829: add tooltip to devconsole monitoring graph #4455

openshift-merge-robot merged 1 commit into from
Feb 26, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 25, 2020

This is an automated cherry-pick of #4363

/assign vikram-raj

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 25, 2020
Merged
4 tasks
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1804638, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1804638 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1804638: add tooltip to devconsole monitoring graph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Feb 25, 2020
@vikram-raj
Copy link
Member

vikram-raj commented Feb 25, 2020

/retitle [release-4.4] Bug 1806829: add tooltip to devconsole monitoring graph

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1804638: add tooltip to devconsole monitoring graph [release-4.4] Bug 1806829: add tooltip to devconsole monitoring graph Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1806829, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1806829: add tooltip to devconsole monitoring graph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member

vikram-raj commented Feb 25, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2020

@vikram-raj: This pull request references Bugzilla bug 1806829, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143
sahil143 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Verified locally

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@spadgett spadgett added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 25, 2020
@spadgett
Copy link
Member

spadgett commented Feb 25, 2020

/retest

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Feb 25, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, openshift-cherrypick-robot, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e15ef9a into openshift:release-4.4 Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1806829 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1806829: add tooltip to devconsole monitoring graph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 28, 2020
meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025
@openshift-merge-robot
Merge pull request openshift#4455 from openshift-cherrypick-robot/che…
5dc451b 
…rry-pick-4363-to-release-4.4

[release-4.4] Bug 1806829: add tooltip to devconsole monitoring graph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

1 more reviewer

@sahil143 sahil143 sahil143 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vikram-raj vikram-raj

@sahil143 sahil143

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @vikram-raj @spadgett @andrewballantyne @openshift-bot @sahil143 @openshift-merge-robot