[release-4.4] Bug 1806815: Monitoring Dashboards: Remove broken bar chart links & clean up #4493
Conversation
The `Off` text was not being displayed.
Call `changeBoard()` from `useEffect` hook instead of during render.
This is a bug fix since `changeBoard()` changes the component state, so
it shouldn't be called during render.
Speed up dashboard switching by
- Adding a Redux action for updating all dashboard variables at once
- Setting the `isLoading` flag to `true` immediately for `query`
variables, which prevents that flag being quickly switched from
`false` to `true` and triggering unnecessary renders
The bar chart panels were linking to the Query Browser page, but the links were broken. Fixed by removing the links since the other panels are not links and we should be consistent.
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1804143, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
/retitle [release-4.4] Bug 1806815: Monitoring Dashboards: Remove broken bar chart links & clean up |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/valid-bug
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1806815, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1806815 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…rry-pick-4454-to-release-4.4 [release-4.4] Bug 1806815: Monitoring Dashboards: Remove broken bar chart links & clean up
6 participants
This is an automated cherry-pick of #4454
/assign kyoto