Bug 1804143: Monitoring Dashboards: Remove broken bar chart links & clean up #4454
Conversation
The `Off` text was not being displayed.
Call `changeBoard()` from `useEffect` hook instead of during render.
This is a bug fix since `changeBoard()` changes the component state, so
it shouldn't be called during render.
Speed up dashboard switching by
- Adding a Redux action for updating all dashboard variables at once
- Setting the `isLoading` flag to `true` immediately for `query`
variables, which prevents that flag being quickly switched from
`false` to `true` and triggering unnecessary renders
The bar chart panels were linking to the Query Browser page, but the links were broken. Fixed by removing the links since the other panels are not links and we should be consistent.
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@kyoto: This pull request references Bugzilla bug 1804143, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
approved
|
/retest |
| title, | ||
| query, | ||
| data = [], | ||
| isLink = true, |
There was a problem hiding this comment.
Booleans that default to true tend to be confusing. I'd recommend using noLink and flipping the logic.
| data = [], | ||
| isLink = true, | ||
| LabelComponent, | ||
| loading = false, |
There was a problem hiding this comment.
Not new, but do we need the default here since undefined is falsey?
| barWidth, | ||
| delay = undefined, | ||
| humanize = humanizeNumber, | ||
| isLink = true, |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 similar comments
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/verify |
|
@spadgett: Overrode contexts on behalf of spadgett: ci/prow/verify DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@kyoto: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@kyoto: All pull requests linked via external trackers have merged. Bugzilla bug 1804143 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@kyoto: new pull request created: #4493 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
The bar chart panels were linking to the Query Browser page, but the
links were broken. Fixed by removing the links since the other panels
are not links and we should be consistent.
Fix issue where the "Refresh Interval"'s
Offtext was not being displayed.Add
Boardtype to address feedback on PR #4388Call
changeBoard()fromuseEffecthook instead of during render.This is a bug fix since
changeBoard()changes the component state, soit shouldn't be called during render.
Speed up dashboard switching by
isLoadingflag totrueimmediately forqueryvariables, which prevents that flag being quickly switched from
falsetotrueand triggering unnecessary renders