Bug 1804143: Monitoring Dashboards: Remove broken bar chart links & clean up

frontend/public/actions/ui.ts

@@ -28,6 +28,7 @@ export enum ActionType {
   SetCurrentLocation = 'setCurrentLocation',
   MonitoringDashboardsClearVariables = 'monitoringDashboardsClearVariables',
   MonitoringDashboardsPatchVariable = 'monitoringDashboardsPatchVariable',
+  MonitoringDashboardsPatchAllVariables = 'monitoringDashboardsPatchAllVariables',
   MonitoringDashboardsSetPollInterval = 'monitoringDashboardsSetPollInterval',
   MonitoringDashboardsSetTimespan = 'monitoringDashboardsSetTimespan',
   MonitoringDashboardsVariableOptionsLoaded = 'monitoringDashboardsVariableOptionsLoaded',
@@ -269,6 +270,8 @@ export const monitoringDashboardsClearVariables = () =>
   action(ActionType.MonitoringDashboardsClearVariables);
 export const monitoringDashboardsPatchVariable = (key: string, patch: any) =>
   action(ActionType.MonitoringDashboardsPatchVariable, { key, patch });
+export const monitoringDashboardsPatchAllVariables = (variables: any) =>
+  action(ActionType.MonitoringDashboardsPatchAllVariables, { variables });
 export const monitoringDashboardsSetPollInterval = (pollInterval: number) =>
   action(ActionType.MonitoringDashboardsSetPollInterval, { pollInterval });
 export const monitoringDashboardsSetTimespan = (timespan: number) =>
@@ -346,6 +349,7 @@ const uiActions = {
   updateOverviewFilterValue,
   monitoringDashboardsClearVariables,
   monitoringDashboardsPatchVariable,
+  monitoringDashboardsPatchAllVariables,
   monitoringDashboardsSetPollInterval,
   monitoringDashboardsSetTimespan,
   monitoringDashboardsVariableOptionsLoaded,

frontend/public/components/graphs/bar.tsx

@@ -23,13 +23,14 @@ const PADDING_RATIO = 1 / 3;
 export const BarChart: React.FC<BarChartProps> = ({
   barSpacing = 15,
   barWidth = DEFAULT_BAR_WIDTH,
-  title,
-  query,
   data = [],
+  isLink = true,
+  LabelComponent,
+  loading = false,
+  query,
   theme = getCustomTheme(ChartThemeColor.blue, ChartThemeVariant.light, barTheme),
+  title,
   titleClassName,
-  loading = false,
-  LabelComponent,
 }) => {
   const [containerRef, width] = useRefWidth();
 
@@ -46,7 +47,7 @@ export const BarChart: React.FC<BarChartProps> = ({
   return (
     <PrometheusGraph ref={containerRef} title={title} className={titleClassName}>
       {data.length ? (
-        <PrometheusGraphLink query={query}>
+        <PrometheusGraphLink query={isLink ? query : undefined}>
           {data.map((datum, index) => (
             <React.Fragment key={index}>
               <div className="graph-bar__label">
@@ -80,16 +81,17 @@ export const BarChart: React.FC<BarChartProps> = ({
 };
 
 export const Bar: React.FC<BarProps> = ({
+  barSpacing,
+  barWidth,
   delay = undefined,
   humanize = humanizeNumber,
+  isLink = true,
+  LabelComponent,
   metric,
   namespace,
-  barSpacing,
-  barWidth,
-  theme,
   query,
+  theme,
   title,
-  LabelComponent,
 }) => {
   const [response, , loading] = usePrometheusPoll({
     delay,
@@ -101,14 +103,15 @@ export const Bar: React.FC<BarProps> = ({
 
   return (
     <BarChart
-      title={title}
-      query={query}
-      data={data}
       barSpacing={barSpacing}
       barWidth={barWidth}
-      theme={theme}
-      loading={loading}
+      data={data}
+      isLink={isLink}
       LabelComponent={LabelComponent}
+      loading={loading}
+      query={query}
+      theme={theme}
+      title={title}
     />
   );
 };
@@ -119,25 +122,27 @@ type LabelComponentProps = {
 };
 
 type BarChartProps = {
-  LabelComponent?: React.ComponentType<LabelComponentProps>;
   barSpacing?: number;
   barWidth?: number;
+  data?: DataPoint[];
+  isLink?: boolean;
+  LabelComponent?: React.ComponentType<LabelComponentProps>;
+  loading?: boolean;
   query?: string;
   theme?: any; // TODO figure out the best way to import VictoryThemeDefinition
   title?: string;
-  data?: DataPoint[];
   titleClassName?: string;
-  loading?: boolean;
 };
 
 type BarProps = {
-  LabelComponent?: React.ComponentType<LabelComponentProps>;
+  barSpacing?: number;
+  barWidth?: number;
   delay?: number;
   humanize?: Humanize;
+  isLink?: boolean;
+  LabelComponent?: React.ComponentType<LabelComponentProps>;
   metric: string;
   namespace?: string;
-  barSpacing?: number;
-  barWidth?: number;
   query: string;
   theme?: any; // TODO figure out the best way to import VictoryThemeDefinition
   title?: string;

frontend/public/components/monitoring/dashboards/bar-chart.tsx

@@ -6,7 +6,14 @@ import { Bar } from '../../graphs';
 const Label = ({ metric }) => <>{_.values(metric).join()}</>;
 
 const BarChart: React.FC<BarChartProps> = ({ pollInterval, query }) => (
-  <Bar barSpacing={5} barWidth={8} delay={pollInterval} query={query} LabelComponent={Label} />
+  <Bar
+    barSpacing={5}
+    barWidth={8}
+    delay={pollInterval}
+    isLink={false}
+    LabelComponent={Label}
+    query={query}
+  />
 );
 
 type BarChartProps = {

frontend/public/components/monitoring/dashboards/index.tsx

@@ -180,7 +180,7 @@ const SingleVariableDropdown = connect(
 
 const AllVariableDropdowns_: React.FC<AllVariableDropdownsProps> = ({ variables }) => (
   <>
-    {_.map(_.keys(variables.toJS()), (name) => (
+    {variables.keySeq().map((name) => (
       <SingleVariableDropdown key={name} name={name} />
     ))}
   </>
@@ -254,7 +254,7 @@ const PollIntervalDropdown_: React.FC<PollIntervalDropdownProps> = ({
       items={pollIntervalOptions}
       label="Refresh Interval"
       onChange={onChange}
-      selectedKey={formatPrometheusDuration(pollInterval)}
+      selectedKey={pollInterval === null ? pollOffText : formatPrometheusDuration(pollInterval)}
     />
   );
 };
@@ -373,13 +373,12 @@ const Board: React.FC<BoardProps> = ({ rows }) => (
 );
 
 const MonitoringDashboardsPage_: React.FC<MonitoringDashboardsPageProps> = ({
-  clearVariables,
   deleteAll,
   match,
-  patchVariable,
+  patchAllVariables,
 }) => {
   const [board, setBoard] = React.useState();
-  const [boards, setBoards] = React.useState([]);
+  const [boards, setBoards] = React.useState<Board[]>([]);
   const [error, setError] = React.useState();
   const [isLoading, , , setLoaded] = useBoolean(true);
 
@@ -394,7 +393,7 @@ const MonitoringDashboardsPage_: React.FC<MonitoringDashboardsPageProps> = ({
         setLoaded();
         setError(undefined);
 
-        const getBoardData = (item) => ({
+        const getBoardData = (item): Board => ({
           data: JSON.parse(_.values(item?.data)[0]),
           name: item.metadata.name,
         });
@@ -415,31 +414,38 @@ const MonitoringDashboardsPage_: React.FC<MonitoringDashboardsPageProps> = ({
     boards,
   ]);
 
-  const changeBoard = (newBoard: string) => {
-    if (newBoard !== board) {
-      clearVariables();
-
-      const data = _.find(boards, { name: newBoard })?.data;
+  const changeBoard = React.useCallback(
+    (newBoard: string) => {
+      if (newBoard !== board) {
+        const data = _.find(boards, { name: newBoard })?.data;
+
+        const allVariables = {};
+        _.each(data?.templating?.list, (v) => {
+          if (v.type === 'query' || v.type === 'interval') {
+            allVariables[v.name] = ImmutableMap({
+              isHidden: v.hide !== 0,
+              isLoading: v.type === 'query',
+              options: _.map(v.options, 'value'),
+              query: v.type === 'query' ? v.query : undefined,
+              value: _.find(v.options, { selected: true })?.value || v.options?.[0]?.value,
+            });
+          }
+        });
+        patchAllVariables(allVariables);
 
-      _.each(data?.templating?.list as TemplateVariable[], (v) => {
-        if (v.type === 'query' || v.type === 'interval') {
-          patchVariable(v.name, {
-            isHidden: v.hide !== 0,
-            options: _.map(v.options, 'value'),
-            query: v.type === 'query' ? v.query : undefined,
-            value: _.find(v.options, { selected: true })?.value || v.options?.[0]?.value,
-          });
-        }
-      });
+        setBoard(newBoard);
+        history.replace(`/monitoring/dashboards/${newBoard}`);
+      }
+    },
+    [board, boards, patchAllVariables],
+  );
 
-      setBoard(newBoard);
-      history.replace(`/monitoring/dashboards/${newBoard}`);
+  // Default to displaying the first board
+  React.useEffect(() => {
+    if (!board && !_.isEmpty(boards)) {
+      changeBoard(match.params.board || boards?.[0]?.name);
     }
-  };
-
-  if (!board && !_.isEmpty(boards)) {
-    changeBoard(match.params.board || boards?.[0]?.name);
-  }
+  }, [board, boards, changeBoard, match.params.board]);
 
   if (error) {
     return <ErrorAlert message={error} />;
@@ -478,9 +484,8 @@ const MonitoringDashboardsPage_: React.FC<MonitoringDashboardsPageProps> = ({
   );
 };
 const MonitoringDashboardsPage = connect(null, {
-  clearVariables: UIActions.monitoringDashboardsClearVariables,
   deleteAll: UIActions.queryBrowserDeleteAllQueries,
-  patchVariable: UIActions.monitoringDashboardsPatchVariable,
+  patchAllVariables: UIActions.monitoringDashboardsPatchAllVariables,
 })(MonitoringDashboardsPage_);
 
 type TemplateVariable = {
@@ -491,6 +496,22 @@ type TemplateVariable = {
   type: string;
 };
 
+type Row = {
+  panels: Panel[];
+};
+
+type Board = {
+  data: {
+    panels: Panel[];
+    rows: Row[];
+    templating: {
+      list: TemplateVariable[];
+    };
+    title: string;
+  };
+  name: string;
+};
+
 type Variable = {
   isHidden?: boolean;
   isLoading?: boolean;
@@ -521,11 +542,11 @@ type SingleVariableDropdownProps = {
 };
 
 type BoardProps = {
-  rows: Panel[];
+  rows: Row[];
 };
 
 type AllVariableDropdownsProps = {
-  variables: ImmutableMap<string, Variable>;
+  variables: ImmutableMap<string, ImmutableMap<string, any>>;
 };
 
 type TimespanDropdownProps = {
@@ -541,20 +562,19 @@ type PollIntervalDropdownProps = {
 type CardBodyProps = {
   panel: Panel;
   pollInterval: null | number;
-  variables: ImmutableMap<string, Variable>;
+  variables: ImmutableMap<string, ImmutableMap<string, any>>;
 };
 
 type CardProps = {
   panel: Panel;
 };
 
 type MonitoringDashboardsPageProps = {
-  clearVariables: () => undefined;
   deleteAll: () => undefined;
   match: {
     params: { board: string };
   };
-  patchVariable: (key: string, patch: Variable) => undefined;
+  patchAllVariables: (variables: VariablesMap) => undefined;
 };
 
 export default withFallback(MonitoringDashboardsPage, ErrorBoundaryFallback);

frontend/public/reducers/ui.ts

@@ -150,6 +150,12 @@ export default (state: UIState, action: UIAction): UIState => {
         ImmutableMap(action.payload.patch),
       );
 
+    case ActionType.MonitoringDashboardsPatchAllVariables:
+      return state.setIn(
+        ['monitoringDashboards', 'variables'],
+        ImmutableMap(action.payload.variables),
+      );
+
     case ActionType.MonitoringDashboardsSetPollInterval:
       return state.setIn(['monitoringDashboards', 'pollInterval'], action.payload.pollInterval);