Skip to content

Bug 1804143: Graphs: Change Bar component's isLink to noLink #4494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 26, 2020
Merged

Bug 1804143: Graphs: Change Bar component's isLink to noLink #4494

openshift-merge-robot merged 1 commit into from
Feb 26, 2020

Conversation

@kyoto
Copy link
Member

@kyoto kyoto commented Feb 26, 2020 •
edited
Loading

Because booleans that default to true can be confusing.

Addresses feedback on #4454

@kyoto
Graphs: Change Bar component's isLink to noLink
7866c3a 
Because booleans that default to true can be confusing.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring labels Feb 26, 2020
@kyoto kyoto mentioned this pull request Feb 26, 2020
Merged
@spadgett spadgett changed the title Graphs: Change Bar component's isLink to noLink Bug 1804143: Graphs: Change Bar component's isLink to noLink Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020

@kyoto: This pull request references Bugzilla bug 1804143, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1804143: Graphs: Change Bar component's isLink to noLink

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 26, 2020
@spadgett
Copy link
Member

spadgett commented Feb 26, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020

@spadgett: This pull request references Bugzilla bug 1804143, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 26, 2020
spadgett
spadgett approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@spadgett
Copy link
Member

spadgett commented Feb 26, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 26, 2020

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 883c693 into openshift:master Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020

@kyoto: All pull requests linked via external trackers have merged. Bugzilla bug 1804143 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1804143: Graphs: Change Bar component's isLink to noLink

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 26, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 26, 2020

@spadgett: new pull request created: #4504

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto deleted the graphs-bar-change-islink-to-nolink branch February 27, 2020 00:49
@spadgett spadgett added this to the v4.5 milestone Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.5

Development

Successfully merging this pull request may close these issues.

5 participants

@kyoto @openshift-ci-robot @spadgett @openshift-cherrypick-robot @openshift-merge-robot