[release-4.3] Bug 1814075: Mount OCS form when csv is available #4746

afreen23 · 2020-03-16T23:41:10Z

Cherrypick for https://github.com/openshift/console/pull/4723/commits (#4723 )
There were conflicts, hence sending separate PR with resolved conflicts and cherry picking the original commit 5b1e739)

I verified cherry pick commit locally , its genuine:

git cherry upstream/release-4.3 upstream/release-4.4 | grep 5b1e7394fc5d53ed8755812d433c7c62a466e883
+  5b1e7394fc5d53ed8755812d433c7c62a466e883

Summary of conflicts and reasons:

packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx file is not present in 4.3
Import conflicts in packages/ceph-storage-plugin/src/components/modals/storage-class-dropdown.tsx. The file is not using some imports in 4.4 and 4.5 that were used in 4.3

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804107
The OCS form is unmounted when the parent component's state changes. We should render the component only once we have got all the data.
Internally the states of inner children components are getting affected.

Signed-off-by: Afreen Rahman afrahman@redhat.com
(cherry picked from commit 5b1e739)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804107 The OCS form is unmounted when the parent component's state changes. We should render the component only once we have got all the data. Internally the states of inner children components are getting affected. Signed-off-by: Afreen Rahman <afrahman@redhat.com> (cherry picked from commit 5b1e739)

openshift-ci-robot · 2020-03-16T23:41:12Z

@afreen23: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-16T23:45:14Z

@afreen23: This pull request references Bugzilla bug 1814075, which is invalid:

expected dependent Bugzilla bug 1812907 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-03-19T04:52:22Z

/retest

afreen23 · 2020-03-19T15:19:29Z

/bugzilla refresh

openshift-ci-robot · 2020-03-19T15:19:36Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2020-03-19T15:21:14Z

/lgtm /approve

bipuladh · 2020-03-19T15:23:04Z

/lgtm

openshift-ci-robot · 2020-03-19T15:23:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [afreen23,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

afreen23 · 2020-03-19T15:24:31Z

/retest

openshift-ci-robot · 2020-03-19T15:25:08Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T15:25:17Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T15:25:39Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T15:36:36Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T15:37:29Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-03-19T17:12:17Z

/bugzilla refresh

openshift-ci-robot · 2020-03-19T17:12:21Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T17:19:28Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T17:19:58Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T17:35:56Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T17:36:40Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T17:41:37Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-19T17:42:11Z

@afreen23: This pull request references Bugzilla bug 1814075, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1812907 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1812907 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-20T04:33:33Z

@afreen23: All pull requests linked via external trackers have merged. Bugzilla bug 1814075 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[release-4.3] Bug 1814075: Mount OCS form when csv is available

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020

openshift-ci-robot requested review from cloudbehl and rawagner March 16, 2020 23:41

openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Mar 16, 2020

afreen23 changed the title ~~Mount OCS form when csv is available~~ [release-4.3] BUg 1814075: Mount OCS form when csv is available Mar 16, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 16, 2020

afreen23 changed the title ~~[release-4.3] BUg 1814075: Mount OCS form when csv is available~~ [release-4.3] Bug 1814075: Mount OCS form when csv is available Mar 16, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 19, 2020

openshift-ci-robot assigned bipuladh Mar 19, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020

mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 20, 2020

openshift-merge-robot merged commit 23b7ac9 into openshift:release-4.3 Mar 20, 2020

spadgett added this to the v4.3.z milestone May 1, 2020

meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025

Merge pull request openshift#4746 from afreen23/ocs-mount-4.3

234bc4f

[release-4.3] Bug 1814075: Mount OCS form when csv is available

[release-4.3] Bug 1814075: Mount OCS form when csv is available #4746

[release-4.3] Bug 1814075: Mount OCS form when csv is available #4746

Uh oh!

Conversation

afreen23 commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 16, 2020

Uh oh!

openshift-ci-robot commented Mar 16, 2020

Uh oh!

afreen23 commented Mar 19, 2020

Uh oh!

afreen23 commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

bipuladh commented Mar 19, 2020

Uh oh!

bipuladh commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

afreen23 commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

afreen23 commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 19, 2020

Uh oh!

openshift-ci-robot commented Mar 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

afreen23 commented Mar 16, 2020 •

edited

Loading