Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #4676

/assign afreen23

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804107
The OCS form is unmounted when the parent component's state changes. We should render the component only once we have got all the data.
Internally the states of inner children components are getting affected.

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered searching for bug 1804107 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1804107?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.4] Bug 1804107: Mount OCS form when csv is available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin labels Mar 12, 2020
@afreen23
Copy link

/retitle [release-4.4] Bug 1812907: Mount OCS form when csv is available

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1804107: Mount OCS form when csv is available [release-4.4] Bug 1812907: Mount OCS form when csv is available Mar 12, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 12, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1812907, which is invalid:

  • expected dependent Bugzilla bug 1804107 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1812907: Mount OCS form when csv is available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23
Copy link

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link
Author

@afreen23: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnehapk
Copy link
Contributor

gnehapk commented Mar 13, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1812907, which is invalid:

  • expected dependent Bugzilla bug 1804107 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a2batic
Copy link
Contributor

a2batic commented Mar 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@afreen23
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 16, 2020
@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1812907, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1804107 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1804107 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 16, 2020
@bipuladh
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, bipuladh, dboytherealest1000, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit d2babe9 into openshift:release-4.4 Mar 19, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1812907 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1812907: Mount OCS form when csv is available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Author

@afreen23: #4723 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/packages/ceph-storage-plugin/src/components/modals/storage-class-dropdown.tsx
A	frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx deleted in HEAD and modified in Mount OCS form when csv is available. Version Mount OCS form when csv is available of frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx left in tree.
Auto-merging frontend/packages/ceph-storage-plugin/src/components/modals/storage-class-dropdown.tsx
CONFLICT (content): Merge conflict in frontend/packages/ceph-storage-plugin/src/components/modals/storage-class-dropdown.tsx
Patch failed at 0001 Mount OCS form when csv is available

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Mar 23, 2020
meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025
…rry-pick-4676-to-release-4.4

[release-4.4] Bug 1812907: Mount OCS form when csv is available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants