Bug 1804107: Mount OCS form when csv is available #4676
Conversation
|
@afreen23: This pull request references Bugzilla bug 1804107, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
frontend/packages/ceph-storage-plugin/src/components/modals/storage-class-dropdown.tsx
Outdated
Show resolved
Hide resolved
afreen23
force-pushed
the
storage-class-fix
branch
from
48e35f4 to
777e9aa
Compare
frontend/packages/ceph-storage-plugin/src/components/ocs-install/create-form.tsx
Outdated
Show resolved
Hide resolved
afreen23
force-pushed
the
storage-class-fix
branch
from
777e9aa to
b8ca4a7
Compare
frontend/packages/ceph-storage-plugin/src/components/ocs-install/create-form.tsx
Outdated
Show resolved
Hide resolved
afreen23
force-pushed
the
storage-class-fix
branch
from
5609d32 to
0340b84
Compare
afreen23
changed the title
|
@afreen23: This pull request references Bugzilla bug 1804107, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
afreen23
force-pushed
the
storage-class-fix
branch
2 times, most recently
from
d1eda5a to
0590e68
Compare
openshift-ci-robot
added
size/M
|
@afreen23: This pull request references Bugzilla bug 1804107, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/approve |
|
LGTM |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
There was a problem hiding this comment.
Requires optional chaining here. It will error out when we select no default storage class in dropdrown.
https://github.com/openshift/console/blob/master/frontend/packages/ceph-storage-plugin/src/components/modals/storage-class-dropdown.tsx#L46
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm cancel |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804107 The OCS form is unmounted when the parent component's state changes. We should render the component only once we have got all the data. Internally the states of inner children components are getting affected. Signed-off-by: Afreen Rahman <afrahman@redhat.com>
afreen23
force-pushed
the
storage-class-fix
branch
from
0590e68 to
b2830b2
Compare
I checked, this is not related to this bug, but I fixed it. Thanks for the review :) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a2batic, cloudbehl, gnehapk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cerry-pick release-4.4 |
|
/cherry-pick release-4.4 |
|
@afreen23: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@afreen23: All pull requests linked via external trackers have merged. Bugzilla bug 1804107 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@afreen23: new pull request created: #4723 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
10 participants
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804107
The OCS form is unmounted when the parent component's state changes and it re renders. We should render the component only once we have got all the data. (i.e csv)
Internally the states of inner children components are getting affected due to this behavior.
Additional Info on internal state management of the dropdown:
The selectedKey value is set to null in storage class dropdown. This happens when the parent components gets re-rendered and the shouldComponentupdate lifecycle hook returns false because the current state === next state. This does not happen on initial render, since props were different (firehose takes some time to fetch data). Also, if the state is changed by selection then it got set too.