Bug 1829504: Enable operator developer message to display in the uninstall operator modal...

[sg00dwin]

when removing an installed operator subscription from the subscription details page.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sg00dwin
To complete the pull request process, please assign jeff-phillips-18
You can assign the PR to them by writing /assign @jeff-phillips-18 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/packages/operator-lifecycle-manager/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[benjaminapetersen]

I dont think the ResourceKebob handles a third arg:

// kebab.tsx
actions.map((a) => a(kindObj, resource)),

console/frontend/public/components/utils/kebab.tsx

Line 361 in a294f78

actions.map((a) => a(kindObj, resource)),

[sg00dwin]

@benjaminapetersen Would that be the cause of this frontend test error?

TypeError: Cannot destructure property `clusterServiceVersions` of 'undefined' or 'null'.
      at Array.Object.<anonymous>.menuActions (packages/operator-
lifecycle-manager/src/components/subscription.tsx:108:1)

[benjaminapetersen]

Yup, this:

(kind, obj, { clusterServiceVersions }) => {

says "I get kind, obj, and a 3rd arg that I'll pluck out clusterServiceVersion. but that 3rd object is never passed, so it is always null/undefined, and null never has null.clusterServiceVersion.

[spadgett]

Right, this won't work for the list view when fix #4916 merges.

[benjaminapetersen]

If you are wanting to pass the third property, then you need to update kebab.tsx to support it:

// you could update this, if you need to
actions.map((a) => a(kindObj, resource, csv)), 
// but it looks like _.get(obj, 'status.installedCSV'); installedCSV is already part of obj, so you may not need this.

[openshift-ci-robot]

@sg00dwin: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/frontend	4792beb	link	/test frontend
ci/prow/e2e-gcp-console	4792beb	link	/test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@sg00dwin: This pull request references Bugzilla bug 1829504, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1829504: Enable operator developer message to display in the uninstall operator modal...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.