Skip to content

Bug 1820769: Register Subscription list page from plugin #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 22, 2020
Merged

Bug 1820769: Register Subscription list page from plugin #4916

openshift-merge-robot merged 1 commit into from
Apr 22, 2020

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 3, 2020

/assign @TheRealJon

Screenshot_2020-04-03 Search · OKD

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2020

@spadgett: This pull request references Bugzilla bug 1820769, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1820769: Register Subscription list page from plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM labels Apr 3, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2020
spadgett
spadgett commented Apr 3, 2020
View reviewed changes
frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx Outdated
Copy link
Member Author

@spadgett spadgett Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the help text as in #4760. It doesn't work well in Home -> Search where this list appears.

@spadgett
Copy link
Member Author

spadgett commented Apr 3, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 3, 2020

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 3, 2020

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member Author

spadgett commented Apr 3, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 3, 2020

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett mentioned this pull request Apr 8, 2020
Closed
benjaminapetersen
benjaminapetersen approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 16, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Apr 17, 2020

/hold
for #5100

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@spadgett
Copy link
Member Author

spadgett commented Apr 17, 2020

/hold cancel
/lgtm cancel
test errors

@openshift-ci-robot openshift-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 17, 2020
@spadgett spadgett force-pushed the fix-subscriptions-list branch from f86fe7e to 2b6246b Compare April 22, 2020 14:41
@spadgett
Copy link
Member Author

spadgett commented Apr 22, 2020

Updated with the test fix, @benjaminapetersen another look?

benjaminapetersen
benjaminapetersen approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cddaf84 into openshift:master Apr 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 22, 2020

@spadgett: All pull requests linked via external trackers have merged: openshift/console#4916. Bugzilla bug 1820769 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1820769: Register Subscription list page from plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2020

@spadgett: new pull request created: #5162

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2020

@spadgett: new pull request created: #5163

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2020
Merged
@spadgett spadgett deleted the fix-subscriptions-list branch April 24, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.5

Development

Successfully merging this pull request may close these issues.

7 participants

@spadgett @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @benjaminapetersen @TheRealJon @openshift-merge-robot