-
Notifications
You must be signed in to change notification settings - Fork 667
Support showing how a PipelineRun was triggered #5011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support showing how a PipelineRun was triggered #5011
Conversation
frontend/packages/dev-console/src/components/pipelines/modals/start-pipeline/submit-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines/modals/triggers/AddTriggerModal.tsx
Outdated
Show resolved
Hide resolved
...ages/dev-console/src/components/pipelines/modals/triggers/TriggerBindingSelectorDropdown.tsx
Outdated
Show resolved
Hide resolved
...ages/dev-console/src/components/pipelines/modals/triggers/TriggerBindingSelectorDropdown.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines/modals/triggers/resource-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines/modals/start-pipeline/submit-utils.ts
Outdated
Show resolved
Hide resolved
ae6f886 to
6797469
Compare
|
Looks like some of the tests are failing here. |
d6b51b9 to
df8806e
Compare
df8806e to
0a61298
Compare
|
Verified both the manual and trigger scenario, works fine. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |

Fixes:
https://issues.redhat.com/browse/ODC-3323
Analysis / Root cause:
With the addition of Tekton Triggers, we now have a desire to separate who started a Pipeline Run... was it the Trigger or a user?
Solution Description:
Two fold solution:
Screen shots / Gifs for design review:
@openshift/team-devconsole-ux
Unit test coverage report:
Test setup:
Browser conformance: