Skip to content

Conversation

@andrewballantyne
Copy link
Contributor

@andrewballantyne andrewballantyne commented Apr 12, 2020

Fixes:
https://issues.redhat.com/browse/ODC-3323

Analysis / Root cause:
With the addition of Tekton Triggers, we now have a desire to separate who started a Pipeline Run... was it the Trigger or a user?

Solution Description:
Two fold solution:

  • For Manual starts - Inject the username into the labels of a Pipeline Run as it is created to carry forward who started it
  • For Trigger kicks - Read the provided label from the Operator to link back to the Event Listener

Screen shots / Gifs for design review:

@openshift/team-devconsole-ux

Kapture 2020-04-12 at 13 08 15

Unit test coverage report:

  • Figure out what unit tests, if any we can write here (most functionality is hooks)

Test setup:

  • Install the Pipeline Operator
  • Manually triggering a Pipeline from any button in the UI should tag the username onto the PLR as it is created
  • Installing a Trigger and executing it will show the resource link (see me if you need some resources / steps to get up and running fast to test this)

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Apr 12, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2020
@karthikjeeyar
Copy link
Contributor

Tested it with developer user, it works fine.
image

@karthikjeeyar
Copy link
Contributor

Looks like some of the tests are failing here.

@andrewballantyne andrewballantyne mentioned this pull request Apr 15, 2020
5 tasks
@andrewballantyne andrewballantyne force-pushed the show-trigger-origin branch 2 times, most recently from d6b51b9 to df8806e Compare April 15, 2020 20:55
@karthikjeeyar
Copy link
Contributor

karthikjeeyar commented Apr 16, 2020

Verified both the manual and trigger scenario, works fine.

@karthikjeeyar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 205c4ca into openshift:master Apr 16, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants