Bug 1777129: Tighten cipher usage to library-go

[jhadvig]

Use the cipher suites that are provided by the OpenShift library-go as the reasonable defaults, based on openshift/oauth-proxy#130

/assign @spadgett
cc'ing @stlaz

[openshift-ci-robot]

@jhadvig: This pull request references Bugzilla bug 1777129, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1777129: Tighten cipher usage to library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/test e2e-gcp-console

[spadgett]

I believe we need to update it here as well:

https://github.com/spadgett/console/blob/4e0e7872b60f583d07f69c8ea146eea7d783ca42/cmd/bridge/main.go#L636-L645

[spadgett]

Can you remove pkg/crypto from console if it's no longer needed?

[jhadvig]

yeah, we probably should!

[jhadvig]

The line you you are mentioning was changed but the second commit:

[jhadvig]

@spadgett I've removed the console's crypto pkg.
PTAL :)

[spadgett]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhadvig]

/test e2e-gcp-console

[openshift-ci-robot]

@jhadvig: All pull requests linked via external trackers have merged: openshift/console#6292, openshift/console#3389. Bugzilla bug 1777129 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1777129: Tighten cipher usage to library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@jhadvig: #6292 failed to apply on top of branch "release-4.5":

Applying: Add github.com/openshift/library-go to get crypto pkg
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add github.com/openshift/library-go to get crypto pkg
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.