Skip to content

Conversation

@stlaz
Copy link

@stlaz stlaz commented Aug 13, 2019

Use the cipher suites that are provided by the OpenShift library-go
as the reasonable defaults.

cc @enj @mrogers950


I think I'll need to create separate bugzillas for each the backport, the original fix included...

InfoSec812 and others added 4 commits August 13, 2019 15:23
@openshift-ci-robot
Copy link

@stlaz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[4.1]: Tighten cipher usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 13, 2019
@openshift-ci-robot
Copy link

@stlaz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[4.1]: Tighten cipher usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member

eparis commented Aug 20, 2019

This PR has no review, no bug attached (which depends on a 4.2 bug), and thus no QE review in master. All of these things need done.

@sttts
Copy link

sttts commented Aug 26, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2019
@sttts
Copy link

sttts commented Aug 26, 2019

/retest

@stlaz stlaz changed the title [4.1]: Tighten cipher usage Bug 1748212: [4.1]: Tighten cipher usage Sep 3, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 3, 2019
@openshift-ci-robot
Copy link

@stlaz: This pull request references Bugzilla bug 1748212, which is invalid:

  • expected dependent Bugzilla bug 1748210 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1748212: [4.1]: Tighten cipher usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019
@stlaz
Copy link
Author

stlaz commented Sep 3, 2019

Added a BZ and the fix to travis CI so that the tests should pass now.

@stlaz stlaz force-pushed the cipher_suites_4.1 branch from 5f5f95a to a8e2905 Compare September 4, 2019 10:09
@stlaz
Copy link
Author

stlaz commented Sep 4, 2019

Travis was still using the old config file, trying to bump go version for its builds to see if this makes it use the new config instead

@stlaz stlaz force-pushed the cipher_suites_4.1 branch from a8e2905 to a48ed58 Compare September 4, 2019 10:14
@stlaz
Copy link
Author

stlaz commented Sep 12, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 12, 2019
@openshift-ci-robot
Copy link

@stlaz: This pull request references Bugzilla bug 1748212, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 12, 2019
@mfojtik
Copy link

mfojtik commented Sep 17, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@mfojtik
Copy link

mfojtik commented Sep 17, 2019

/approve

@mfojtik mfojtik added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mfojtik, stlaz, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 19, 2019
@openshift-merge-robot openshift-merge-robot merged commit 528d965 into openshift:release-4.1 Sep 19, 2019
@openshift-ci-robot
Copy link

@stlaz: All pull requests linked via external trackers have merged. Bugzilla bug 1748212 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1748212: [4.1]: Tighten cipher usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants