-
Notifications
You must be signed in to change notification settings - Fork 152
Bug 1748212: [4.1]: Tighten cipher usage #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1748212: [4.1]: Tighten cipher usage #130
Conversation
Use the cipher suites that are provided by the OpenShift library-go as the reasonable defaults.
|
@stlaz: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stlaz: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR has no review, no bug attached (which depends on a 4.2 bug), and thus no QE review in master. All of these things need done. |
|
/lgtm |
|
/retest |
|
@stlaz: This pull request references Bugzilla bug 1748212, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Added a BZ and the fix to travis CI so that the tests should pass now. |
5f5f95a to
a8e2905
Compare
|
Travis was still using the old config file, trying to bump go version for its builds to see if this makes it use the new config instead |
a8e2905 to
a48ed58
Compare
|
/bugzilla refresh |
|
@stlaz: This pull request references Bugzilla bug 1748212, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mfojtik, stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@stlaz: All pull requests linked via external trackers have merged. Bugzilla bug 1748212 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use the cipher suites that are provided by the OpenShift library-go
as the reasonable defaults.
cc @enj @mrogers950
I think I'll need to create separate bugzillas for each the backport, the original fix included...