Update i18n scripts #7030
Merged
Update i18n scripts #7030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
requested changes
Oct 29, 2020
Member
|
/assign |
rebeccaalpert
force-pushed
the
i18n-script
branch
3 times, most recently
from
8009367 to
fcd277f
Compare
rebeccaalpert
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
rebeccaalpert
force-pushed
the
i18n-script
branch
from
fcd277f to
a1292d4
Compare
rebeccaalpert
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
spadgett
reviewed
Nov 3, 2020
rebeccaalpert
force-pushed
the
i18n-script
branch
2 times, most recently
from
38ff210 to
bdb7aed
Compare
rebeccaalpert
force-pushed
the
i18n-script
branch
from
bdb7aed to
0145470
Compare
Contributor
Author
|
Rebased package.json. |
spadgett
reviewed
Nov 11, 2020
rebeccaalpert
force-pushed
the
i18n-script
branch
3 times, most recently
from
3b7eefb to
85f655e
Compare
Contributor
Author
|
This is ready for review again @spadgett. It blocks the Korean work for next sprint and would make importing files from Terry easier. |
spadgett
reviewed
Nov 13, 2020
Updated script to export pos rather than pot files based on the latest info from our translation contact. I fixed a bug where we couldn't use underscores in keys and also appended the language to the header fields so that information is included. Will add additional fields as necessary. The script now also adds in existing translations and now saves all pos to the same location. I also added a bash script I used to export all pos across the application and updated our po import script to be more flexible.
rebeccaalpert
force-pushed
the
i18n-script
branch
from
85f655e to
edbfd40
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
rebeccaalpert
added a commit
to rebeccaalpert/console
that referenced
this pull request
Nov 17, 2020
Added moment.js locale for Korean, removed last language reference in script, updated bash script from openshift#7030 to export Korean po files, and added timestamp in ko folder in public/locales. Fixes https://issues.redhat.com/browse/CONSOLE-2461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the i18n-to-pot script to export pos rather than pot files based on the latest info from translation. I also added a bash script so we can pull out all pos programmatically.
i18n to PO script additions:
_package=${package}at the end so I can sort them programmaticallyPO to i18n script additions:
_package=${package}so it can sort them into the correct locale folders