CONSOLE-2461: Add infrastructure for Korean #7226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
added
the
do-not-merge/hold
openshift-ci-robot
added
the
component/core
Added moment.js locale for Korean, removed last language reference in script, updated bash script from openshift#7030 to export Korean po files, and added timestamp in ko folder in public/locales. Fixes https://issues.redhat.com/browse/CONSOLE-2461
rebeccaalpert
force-pushed
the
i18n-korean
branch
from
0017da3 to
34c3b11
Compare
rebeccaalpert
removed
the
do-not-merge/hold
Contributor
Author
|
Rebased and added "ko" to the webpack supported locales list. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
Author
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added moment.js locale for Korean, removed last language reference in script, updated bash script from #7030 to export Korean po files, and added timestamp in ko folder in public/locales.
Blocked by #7187; need to add "ko" to list of supported locales in https://github.com/openshift/console/pull/7187/files#diff-a7def86cc36a2178b4ee07b000c53d49e04068db4bc85967c0758578a2f37700R210.
Fixes https://issues.redhat.com/browse/CONSOLE-2461.