Add VM Create to Dev console #7188

glekner · 2020-11-11T17:32:19Z

No description provided.

jelkosz · 2020-11-30T15:47:51Z

/hold cancel
design got approved, unholding

rohitkrai03 · 2020-11-30T16:29:33Z

frontend/packages/dev-console/src/components/catalog/details/CatalogDetailsPanel.tsx

Yeah, this does affect all the other providers. It would be better if we remove the spacing from the providers along with this change. Although looking at the code it seems only useBuilderImages provider added extra spacing by using <hr/> which can be removed here. All other providers use PF components or SyncMarkdown component that adds the spacing for them. Not sure what we can do about them. cc: @christianvogt

FYI, the above change adds extra spacing with current catalog providers as shown below-

glekner · 2020-12-01T10:00:59Z

/retest

glekner · 2020-12-01T14:30:46Z

@christianvogt @rawagner @suomiy please lgtm

christianvogt · 2020-12-01T20:59:56Z

I'm fine with the removal of the <hr> in the builder image screen but that's also a @openshift/team-devconsole-ux call
(screenshot: https://user-images.githubusercontent.com/6041994/100635998-3936dc00-3357-11eb-9ea5-869d823c8679.png)

christianvogt

works well.
Couple minor comments.

christianvogt · 2020-12-01T21:15:13Z

...packages/kubevirt-plugin/src/components/create-vm/dev-console/dev-console-create-vm-form.tsx

To respect the user's preference, do not include the view type. This will bring the user to either the graph or list list view. Unless of course UX wants to force the user to the graph.

Suggested change

`/topology/ns/${getNamespace(vm)}?view=graph&selectId=${getUID(

`/topology/ns/${getNamespace(vm)}?selectId=${getUID(

christianvogt · 2020-12-01T21:17:10Z

frontend/packages/kubevirt-plugin/src/plugin.tsx

rawagner · 2020-12-02T10:20:58Z

...packages/kubevirt-plugin/src/components/create-vm/dev-console/dev-console-create-vm-form.tsx

this should be one translation

Suggested change

{t('kubevirt-plugin~Virtual machine template')}: <strong>{templateParam}</strong>{' '}

{t('kubevirt-plugin~Virtual machine template {{ templateParam }} not found', { templateParam })}

rawagner · 2020-12-02T10:22:34Z

...packages/kubevirt-plugin/src/components/create-vm/dev-console/dev-console-create-vm-form.tsx

Suggested change

label="Virtual Machine Template"

label={t('Virtual Machine Template')}

rawagner · 2020-12-02T10:23:04Z

...packages/kubevirt-plugin/src/components/create-vm/dev-console/dev-console-create-vm-form.tsx

missing i18n

rawagner · 2020-12-02T10:25:38Z

...d/packages/kubevirt-plugin/src/components/create-vm/dev-console/use-catalog-vm-templates.tsx

missing i18n

rawagner · 2020-12-02T10:26:23Z

...d/packages/kubevirt-plugin/src/components/create-vm/dev-console/use-catalog-vm-templates.tsx

missing i18n

rawagner · 2020-12-02T10:28:55Z

frontend/packages/kubevirt-plugin/src/components/create-vm/tabs/select-template.tsx

rebase error - i18n was removed

rawagner · 2020-12-02T10:28:59Z

frontend/packages/kubevirt-plugin/src/components/create-vm/tabs/select-template.tsx

rebase error - i18n was removed

rawagner · 2020-12-02T10:29:37Z

frontend/packages/kubevirt-plugin/src/plugin.tsx

Suggested change

// t('Create a Virtual Machine from a template')

// t('kubevirt-plugin~Create a Virtual Machine from a template')

rawagner · 2020-12-02T11:25:07Z

/lgtm

openshift-ci-robot · 2020-12-02T11:25:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot requested review from atiratree and spadgett November 11, 2020 17:32

openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Nov 11, 2020

glekner marked this pull request as draft November 11, 2020 17:33

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2020

glekner changed the title ~~Add VM Create to Dev console~~ WIP: Add VM Create to Dev console Nov 11, 2020

glekner force-pushed the dev-console-add-vm branch 5 times, most recently from ea6e74d to cdac38d Compare November 12, 2020 11:14

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2020

glekner force-pushed the dev-console-add-vm branch from cdac38d to 2661452 Compare November 15, 2020 10:59

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2020

glekner force-pushed the dev-console-add-vm branch 8 times, most recently from 09b9cde to 94187cd Compare November 19, 2020 15:44

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2020

glekner force-pushed the dev-console-add-vm branch from 94187cd to cec0ee1 Compare November 20, 2020 10:32

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2020

glekner changed the title ~~WIP: Add VM Create to Dev console~~ Add VM Create to Dev console Nov 20, 2020

glekner marked this pull request as ready for review November 20, 2020 10:33

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2020

glekner force-pushed the dev-console-add-vm branch 2 times, most recently from 8c6f079 to d412cf1 Compare November 22, 2020 09:59

glekner force-pushed the dev-console-add-vm branch 4 times, most recently from 4df114b to ce8ca45 Compare November 30, 2020 13:24

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020

rohitkrai03 suggested changes Nov 30, 2020

View reviewed changes

glekner force-pushed the dev-console-add-vm branch 2 times, most recently from ce8ca45 to 7cdc11f Compare December 1, 2020 09:47

glekner force-pushed the dev-console-add-vm branch 3 times, most recently from ed5f908 to efcc1e3 Compare December 1, 2020 14:25

spadgett removed their request for review December 1, 2020 14:38

christianvogt reviewed Dec 1, 2020

View reviewed changes

glekner force-pushed the dev-console-add-vm branch from efcc1e3 to 911088a Compare December 2, 2020 09:58

rawagner suggested changes Dec 2, 2020

View reviewed changes

openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020

glekner force-pushed the dev-console-add-vm branch from 911088a to d570e2b Compare December 2, 2020 10:51

add create vm flow to dev console

adc3e03

glekner force-pushed the dev-console-add-vm branch from d570e2b to adc3e03 Compare December 2, 2020 10:53

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020

openshift-merge-robot merged commit 2b520d1 into openshift:master Dec 2, 2020

invincibleJai mentioned this pull request Dec 3, 2020

Bug 1903917: adds feature flag to catalog item provider #7400

Merged

spadgett added this to the v4.7 milestone Dec 9, 2020

	`/topology/ns/${getNamespace(vm)}?view=graph&selectId=${getUID(
	`/topology/ns/${getNamespace(vm)}?selectId=${getUID(

	{t('kubevirt-plugin~Virtual machine template')}: <strong>{templateParam}</strong>{' '}
	{t('kubevirt-plugin~Virtual machine template {{ templateParam }} not found', { templateParam })}

	label="Virtual Machine Template"
	label={t('Virtual Machine Template')}

	// t('Create a Virtual Machine from a template')
	// t('kubevirt-plugin~Create a Virtual Machine from a template')

Add VM Create to Dev console #7188

Add VM Create to Dev console #7188

Uh oh!

Conversation

glekner commented Nov 11, 2020

Uh oh!

jelkosz commented Nov 30, 2020

Uh oh!

rohitkrai03 Nov 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

glekner commented Dec 1, 2020

Uh oh!

glekner commented Dec 1, 2020

Uh oh!

christianvogt commented Dec 1, 2020

Uh oh!

christianvogt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rawagner commented Dec 2, 2020

Uh oh!

openshift-ci-robot commented Dec 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

rohitkrai03 Nov 30, 2020 •

edited

Loading