Skip to content

Bug 1903917: adds feature flag to catalog item provider #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 3, 2020
Merged

Bug 1903917: adds feature flag to catalog item provider #7400

openshift-merge-robot merged 1 commit into from
Dec 3, 2020
+6 −0

Conversation

@invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Dec 3, 2020 •
edited
Loading

Fixes:

https://issues.redhat.com/browse/ODC-5204

Description:

Click on Catalog / database from Developer perspective add flow , doesn't work and shows below error

image

Solution:

plugin Catalog/ItemProvider and 'Catalog/ItemType' needs to be feature flagged

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Dec 3, 2020
@invincibleJai
Copy link
Member Author

invincibleJai commented Dec 3, 2020

@glekner PTAL , plugins added as part of #7188

rohitkrai03
rohitkrai03 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1910f99 into openshift:master Dec 3, 2020
@glekner
Copy link
Contributor

glekner commented Dec 3, 2020

thanks for this @invincibleJai

@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@invincibleJai invincibleJai changed the title adds feature flag to catalog item provider Bug 1903917: adds feature flag to catalog item provider Dec 14, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 14, 2020

@invincibleJai: All pull requests linked via external trackers have merged:

Bugzilla bug 1903917 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1903917: adds feature flag to catalog item provider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glekner glekner Awaiting requested review from glekner

@atiratree atiratree Awaiting requested review from atiratree

1 more reviewer

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rohitkrai03 rohitkrai03

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.7

Development

Successfully merging this pull request may close these issues.

6 participants

@invincibleJai @openshift-ci-robot @glekner @rohitkrai03 @spadgett @openshift-merge-robot