-
Notifications
You must be signed in to change notification settings - Fork 667
CONSOLE-2527: Add translations from Sprint 197 #8404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2527: Add translations from Sprint 197 #8404
Conversation
4d90c11 to
fdf01a9
Compare
|
I manually updated many of the translation inconsistencies in commit #3. I didn't address plurals, the missing tag issue in the Korean translation of pipelines-plugin, the "Okay, got it!" change, or inconsistent capitalization (not sure if capitalization stuff is worth approaching). Will reach out to Terry's team on remaining non-capitalization related items. |
spadgett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888
|
/label qe-approved |
|
@rebeccaalpert You'll need to rebase. @sferich888 PTAL, thanks! |
Includes Japanese, Simplified Chinese, and Korean.
fdf01a9 to
36e242e
Compare
|
Rebased; probably lost lgtm. |
|
/retest |
spadgett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label px-approved |
|
/hold cancel |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jelkosz Do you know who can help us troubleshoot the kubevirt tests? It looks like the failure is unrelated to the PR:
|
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This includes Japanese, Simplified Chinese, and Korean.
I went through the files looking for English strings with bad grammar and inconsistencies in the translation files.
All changes related to English file issues are in commit #2. I haven't made any changes to reflect the inconsistencies in the translation files (see below).
Inconsistencies in files:
Chinese:
Korean:
1. frontend/packages/console-app/locales/ko/nodes.json
Pod is capitalized inconsistently, but this could be an "us" issue: (No Pods found for this resource.": "이 리소스에 대한 Pod가 없습니다." vs. "Hide waiting pods with errors": "오류가 있는 pod 대기 창 숨기기"
Many plurals were not changed at all - was this intentional? Examples:
Japanese:
A couple of singular items are translated while the plural is not:
Pod capitalization is inconsistent and many plurals were not updated; not sure if that was intentional.