Skip to content

Conversation

@rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Mar 17, 2021

This includes Japanese, Simplified Chinese, and Korean.

I went through the files looking for English strings with bad grammar and inconsistencies in the translation files.

All changes related to English file issues are in commit #2. I haven't made any changes to reflect the inconsistencies in the translation files (see below).

Inconsistencies in files:

Chinese:

  1. frontend/public/locales/zh/details-page.json
  • "Edit annotations": "编辑注解" was changed to “Edit annotations": "Pod 注解", (this is not correct and we’ve brought this up before with translation. We've manually edited it before, but it will be overwritten until it's changed in Memsource.)
  • Many plurals were not changed at all - was this intentional?
    • "ServiceClasses": "ServiceClasses",
    • "ServicePlans": "ServicePlans",
    • "ServiceBindings": "ServiceBindings",
    • "MachineConfigs": "MachineConfigs",
  1. frontend/packages/knative-plugin/locales/zh/knative-plugin.json 
  • Sink is capitalized inconsistently in translations - should it be consistent?
  1. frontend/packages/dev-console/locales/zh/devconsole.json
  • “Dockerfile” was changed to “Docker” in the translation. It should be “Dockerfile;" It’s “Dockerfile elsewhere in the translation file.
  1. frontend/packages/console-app/locales/zh/nodes.json
  • "Mark as unschedulable": "将节点标记为不可调度。", - Period needs removal in Memsource (we've discussed this before and removed the period on our end before. This will keep getting overwritten unless it's changed in Memsource.)
  1. frontend/public/locales/zh/modal.json 
  • "Edit annotations": "编辑注解" was changed to “Edit annotations": "Pod 注解", (this is not correct and we’ve brought this up before with translation. We've manually edited it before, but it will be overwritten until it's changed in Memsource.)
  1. frontend/public/locales/zh/public.json
  • "Home": "主页" was changed to "Home": "家", - Translation had said to use the former and we'd manually updated our files; this needs to be changed in Memsource or it will continue to get overwritten.
  • Pod is inconsistently capitalized (could be an "us" issue): "No Pods found for this resource.": "没有找到此资源的 Pod。", vs "Hide waiting pods with errors": "隐藏有错误的等待的 pod",
  • Plural ResourceKinds have not been changed at all - was this intentional?
    • "DaemonSets": "DaemonSets",
    • "ResourceQuotas": "ResourceQuotas",
    • "StatefulSets": "StatefulSets",
    • "ConfigMaps": "ConfigMaps",
    • "CronJobs": "CronJobs",
    • "HorizontalPodAutoscalers": "HorizontalPodAutoscalers",
    • "NetworkPolicies": "NetworkPolicies",
    • "PersistentVolumes": "PersistentVolumes",
    • "PersistentVolumeClaims": "PersistentVolumeClaims",
    • "StorageClasses": "StorageClasses",
    • "VolumeSnapshots": "VolumeSnapshots",
    • "VolumeSnapshotClasses": "VolumeSnapshotClasses”,
    • “ImageStreams": "ImageStreams",
    • "MachineAutoscalers": "MachineAutoscalers",
    • "MachineHealthChecks": "MachineHealthChecks",
    • "MachineConfigs": "MachineConfigs",
    • "MachineConfigPools": "MachineConfigPools",
    • "LimitRanges": "LimitRanges",
    • "CustomResourceDefinitions": "CustomResourceDefinitions",
    • "Prometheuses": "Prometheuses",
    • "ServiceMonitors": "ServiceMonitors",
    • "Alertmanagers": "Alertmanagers",
    • "Reports": "Reports",
    • "ReportQueries": "ReportQueries",
    • "ImageStreamTags": "ImageStreamTags",
    • "ImageStreamImports": "ImageStreamImports",
    • "CertificateSigningRequests": "CertificateSigningRequests”,
    • “ComponentStatuses": "ComponentStatuses",
    • "ProjectRequests": "ProjectRequests",
    • "ClusterRoleBindings": "ClusterRoleBindings",
    • "ClusterRoles": "ClusterRoles",
    • "SelfSubjectAccessReviews": "SelfSubjectAccessReviews",
    • "ResourceAccessReviews": "ResourceAccessReviews",
    • "LocalResourceAccessReviews": "LocalResourceAccessReviews",
    • "Petsets": "Petsets",
    • "ClusterResourceQuotas": "ClusterResourceQuotas",
    • "ClusterServiceBrokers": "ClusterServiceBrokers",
    • "ClusterServiceClasses": "ClusterServiceClasses",
    • "ClusterServicePlans": "ClusterServicePlans",
    • "ServiceInstances": "ServiceInstances",
    • "ServiceBindings": "ServiceBindings",
    • "APIServices": "APIServices",
    • "MachineDeployments": "MachineDeployments",
    • "ClusterOperators": "ClusterOperators",
    • "ClusterVersions": "ClusterVersions",
    • "CSIDrivers": "CSIDrivers",
    • "ClusterAutoscalers": "ClusterAutoscalers",
    • "OAuths": "OAuths",
    • "ConsoleLinks": "ConsoleLinks",
    • "ConsoleCLIDownloads": "ConsoleCLIDownloads",
    • "ConsoleNotifications": "ConsoleNotifications",
    • "ConsoleExternalLogLinks": "ConsoleExternalLogLinks",
    • "ConsoleYAMLSamples": "ConsoleYAMLSamples",
    • "VolumeSnapshotContents": "VolumeSnapshotContents",

Korean:

1. frontend/packages/console-app/locales/ko/nodes.json 

  • "External ID": "외부 IP", - ID was changed to IP; this seems like it may be a typo?
  1. frontend/packages/dev-console/locales/ko/devconsole.json
  • "Developer": "개발자" was changed to "Developer": "Developer", - we had discussed this and the translator for Korean had told us to change it to 개발자; it seems like this was not updated in Memsource.
  1. frontend/packages/pipelines-plugin/locales/ko/pipelines-plugin.json 
  • "Select a Project to view the list of Pipelines or <2>create a Project</2>.": "파이프 라인 목록을 보려면 프로젝트를 선택하십시오.", - the translation is missing the brackets used to generate the "create a Project" link.
  1. frontend/public/locales/ko/search.json
  • "Add to navigation": "검색에 추가합니다.", - shouldn’t have period in translation (net new)
  1. frontend/public/locales/ko/public.json
  • Pod is capitalized inconsistently, but this could be an "us" issue: (No Pods found for this resource.": "이 리소스에 대한 Pod가 없습니다." vs. "Hide waiting pods with errors": "오류가 있는 pod 대기 창 숨기기"

  • 

Many plurals were not changed at all - was this intentional? Examples:

    • "DaemonSets": "DaemonSets",
    • "ResourceQuotas": "ResourceQuotas",
    • "DeploymentConfigs": "DeploymentConfigs",
    • "StatefulSets": "StatefulSets",
    • "ConfigMaps": "ConfigMaps",
    • "CronJobs": "CronJobs",
    • "ReplicaSets": "ReplicaSets",
    • "ReplicationControllers": "ReplicationControllers",
    • "HorizontalPodAutoscalers": "HorizontalPodAutoscalers",
    • "NetworkPolicies": "NetworkPolicies",
    • "PersistentVolumes": "PersistentVolumes",
    • "PersistentVolumeClaims": "PersistentVolumeClaims",
    • "StorageClasses": "StorageClasses",
    • "VolumeSnapshots": "VolumeSnapshots",
    • "VolumeSnapshotClasses": "VolumeSnapshotClasses",
    • "BuildConfigs": "BuildConfigs",
    • "ImageStreams": "ImageStreams",
    • "MachineSets": "MachineSets",
    • "MachineAutoscalers": "MachineAutoscalers",
    • "MachineHealthChecks": "MachineHealthChecks",
    • "MachineConfigs": "MachineConfigs",
    • "MachineConfigPools": "MachineConfigPools",
    • "ServiceAccounts": "ServiceAccounts",
    • "LimitRanges": "LimitRanges",
    • "CustomResourceDefinitions": "CustomResourceDefinitions",
    • "Prometheuses": "Prometheuses",
    • "ServiceMonitors": "ServiceMonitors",
    • "Alertmanagers": "Alertmanagers",
    • "Reports": "Reports",
    • "ReportQueries": "ReportQueries",
    • "ImageStreamTags": "ImageStreamTags",
    • "ImageStreamImports": "ImageStreamImports",
    • "CertificateSigningRequests": "CertificateSigningRequests",
    • "ComponentStatuses": "ComponentStatuses",
    • "ProjectRequests": "ProjectRequests",
    • "ClusterRoleBindings": "ClusterRoleBindings",
    • "ClusterRoles": "ClusterRoles",
    • "SelfSubjectAccessReviews": "SelfSubjectAccessReviews",
    • "ResourceAccessReviews": "ResourceAccessReviews",
    • "LocalResourceAccessReviews": "LocalResourceAccessReviews",
    • "Petsets": "Petsets",
    • "ClusterResourceQuotas": "ClusterResourceQuotas",
    • "ClusterServiceBrokers": "ClusterServiceBrokers",
    • "ClusterServiceClasses": "ClusterServiceClasses",
    • "ClusterServicePlans": "ClusterServicePlans",
    • "ServiceInstances": "ServiceInstances",
    • "ServiceBindings": "ServiceBindings",
    • "APIServices": "APIServices",
    • "MachineDeployments": "MachineDeployments",
    • "ClusterOperators": "ClusterOperators",
    • "ClusterVersions": "ClusterVersions",
    • "CSIDrivers": "CSIDrivers",
    • "ClusterAutoscalers": "ClusterAutoscalers",
    • "OAuths": "OAuths",
    • "ConsoleLinks": "ConsoleLinks",
    • "ConsoleNotifications": "ConsoleNotifications",
    • "ConsoleExternalLogLinks": "ConsoleExternalLogLinks",
    • "ConsoleYAMLSamples": "ConsoleYAMLSamples",
    • "VolumeSnapshotContents": "VolumeSnapshotContents",

Japanese:

  1. frontend/packages/console-app/locales/ja/tour.json
  • “Okay, got it!” Is in English now - changed from Japanese; not sure if that's intentional
  1. frontend/packages/console-shared/locales/ja/console-shared.json 
  • Pod is inconsistently uppercase vs. lowercase (could be an "us" issue): “Pod": "Pod", while “Pods”: “pod” and "to {{count}} Pod_0": "対象: {{count}} Pod"
  1. frontend/public/locales/ja/ingress.json
  • "Ingresses": "Ingress" was changed to "Ingresses": "Ingresses" - was this intentional?
  1. frontend/public/locales/ja/machine-autoscalers.json
  • "MachineAutoscaler details": "Machine Autoscaler の詳細" was changed to "MachineAutoscaler details": "MachineAutoscaler details." This is inconsistent with other translations; was this intentional?
  1. frontend/public/locales/ja/public.json
  • A couple of singular items are translated while the plural is not:

    • "ResourceAccessReview": "リソースアクセスのレビュー",
    • "ResourceAccessReviews": "ResourceAccessReviews",
    • "ReportQuery": "レポートクエリー",
    • "ReportQueries": "ReportQuery",
  • Pod capitalization is inconsistent and many plurals were not updated; not sure if that was intentional.

    • "ResourceQuotas": "ResourceQuotas",
    • “CronJobs": "CronJobs",
    • "HorizontalPodAutoscalers": "HorizontalPodAutoscalers",
    • Ingresses": "Ingresses",
    • "PersistentVolumeClaims": "PersistentVolumeClaims",
    • "VolumeSnapshotClasses": "VolumeSnapshotClasses",
    • "BuildConfigs": "BuildConfigs",
    • "ImageStreams": "ImageStreams",
    • "MachineAutoscalers": "MachineAutoscalers",
    • "CustomResourceDefinitions": "CustomResourceDefinitions",
    • "Prometheuses": "Prometheuses",
    • "Alertmanager": "Alertmanager 0.14.0",
    • "ImageStreamTags": "ImageStreamTags",
    • "ImageStreamImports": "ImageStreamImports",
    • "CertificateSigningRequests": "CertificateSigningRequests",
    • "ComponentStatuses": "ComponentStatuses",
    • "ClusterRoleBindings": "ClusterRoleBindings",
    • "ClusterRoles": "ClusterRoles",
    • "ClusterResourceQuotas": "ClusterResourceQuotas",
    • "ClusterServiceBrokers": "ClusterServiceBrokers",
    • “ClusterServiceClasses": "ClusterServiceClasses",
    • "ClusterServicePlans": "ClusterServicePlans",
    • "MachineDeployments": "MachineDeployments",
    • "ClusterAutoscalers": "ClusterAutoscalers",
    • "ConsoleLinks": "ConsoleLinks",
    • "ConsoleExternalLogLinks": "ConsoleExternalLogLinks",
    • "VolumeSnapshotContents": "VolumeSnapshotContents",

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console labels Mar 17, 2021
@openshift-ci-robot openshift-ci-robot added component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/shared Related to console-shared component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Mar 17, 2021
@rebeccaalpert
Copy link
Contributor Author

CC @spadgett @rh-tchuang @kyoto

@rebeccaalpert rebeccaalpert force-pushed the sprint197-translations branch from 4d90c11 to fdf01a9 Compare March 19, 2021 13:57
@rebeccaalpert
Copy link
Contributor Author

I manually updated many of the translation inconsistencies in commit #3. I didn't address plurals, the missing tag issue in the Korean translation of pipelines-plugin, the "Okay, got it!" change, or inconsistent capitalization (not sure if capitalization stuff is worth approaching). Will reach out to Terry's team on remaining non-capitalization related items.

@rebeccaalpert rebeccaalpert changed the title [WIP] Add translations from Sprint 197 Add translations from Sprint 197 Mar 19, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2021
@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Mar 23, 2021
@yanpzhan
Copy link
Contributor

/label qe-approved

@openshift-ci-robot openshift-ci-robot added qe-approved Signifies that QE has signed off on this PR needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 25, 2021
@spadgett
Copy link
Member

@rebeccaalpert You'll need to rebase.

@sferich888 PTAL, thanks!

@rebeccaalpert rebeccaalpert force-pushed the sprint197-translations branch from fdf01a9 to 36e242e Compare March 30, 2021 16:23
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@rebeccaalpert
Copy link
Contributor Author

Rebased; probably lost lgtm.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2021
@spadgett
Copy link
Member

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sferich888
Copy link

/label px-approved
/unassign @sferich888

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Mar 30, 2021
@spadgett
Copy link
Member

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

@jelkosz Do you know who can help us troubleshoot the kubevirt tests? It looks like the failure is unrelated to the PR:

error: timed out waiting for the condition on kubevirts/kubevirt

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5e88e41 into openshift:master Mar 31, 2021
@spadgett spadgett added this to the v4.8 milestone Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants