Skip to content

Conversation

@ggreer
Copy link
Contributor

@ggreer ggreer commented May 12, 2018

Replace web fonts with the system UI font stack. See https://bitsofco.de/the-new-system-font-stack/
for more info.

  • Reduces our build artifact from 11.3MB to 7.6MB.
  • Improves load times by 10-20% depending on the browser.
  • Avoids a re-flow once the web fonts are downloaded.
  • Avoids an entire class of rendering bugs across platforms. (Web fonts may look good on mac, but we've had issues with kerning & hinting on other platforms. See https://github.com/coreos-inc/bridge/pull/2077)

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2018
@openshift openshift deleted a comment from coreos-ui May 12, 2018
@ggreer
Copy link
Contributor Author

ggreer commented May 12, 2018

jenkins push

@coreos-ui
Copy link

The PR image has been pushed to Quay with tag pr_3_build_275

Replace web fonts with the system UI font stack. See https://bitsofco.de/the-new-system-font-stack/
 for more info.

- Reduces our build artifact from 11.3MB to 7.6MB.
- Improves load times by 10-20% depending on the browser.
- Avoids a re-flow once the web fonts are downloaded.
- Avoids an entire class of rendering bugs across platforms.
@ggreer ggreer force-pushed the remove-web-fonts branch from 5dceb3f to 29d905e Compare May 12, 2018 03:27
@alecmerdler
Copy link
Contributor

We should definitely revisit this again, but closing for now.

jeff-phillips-18 referenced this pull request in jeff-phillips-18/console Oct 7, 2019
afreen23 pushed a commit to afreen23/console that referenced this pull request Oct 18, 2019
Added stack chart and custom legend component
openshift-merge-robot added a commit that referenced this pull request Oct 30, 2019
Expose cdrom in UI - Story #1, #2, #3, #4
openshift-merge-robot pushed a commit that referenced this pull request Nov 22, 2019
better support for mac key variants
rawagner referenced this pull request in rawagner/console Feb 11, 2020
Add 'Clusters' link to left navigation bar
openshift-merge-robot pushed a commit that referenced this pull request Feb 14, 2020
mareklibra added a commit to mareklibra/console that referenced this pull request Jul 2, 2021
…irdArgOptional

Make 3rd arg of k8sKill optional
@jcaianirh jcaianirh mentioned this pull request Aug 26, 2021
openshift-merge-robot pushed a commit that referenced this pull request Jan 20, 2022
TimothyAsirJeyasing pushed a commit to TimothyAsirJeyasing/console that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants