create topology side panel using dynamic plugin extensions#9306

Merged

openshift-merge-robot merged 5 commits intoopenshift:masterfrom

sahil143:topology-sidepanel

Jul 7, 2021

Contributor

sahil143 commented Jun 21, 2021

fixes: https://issues.redhat.com/browse/ODC-5845

This PR creates the topology side panel to use the dynamic plugin extensions

openshift-ci bot added do-not-merge/work-in-progress component/helm labels

openshift-ci bot requested review from jeff-phillips-18 and kyoto

June 21, 2021 13:10

openshift-ci bot added component/sdk component/shared component/topology labels

sahil143 commented

View reviewed changes

frontend/packages/console-shared/src/utils/order-extensions.ts Outdated Show resolved Hide resolved

Contributor Author

sahil143 commented Jun 21, 2021

/retest

sahil143 force-pushed the topology-sidepanel branch 2 times, most recently from 84bcbcd to bae8517 Compare

June 22, 2021 15:14

openshift-ci bot added the component/dev-console label

sahil143 changed the title ~~[WIP] create topology side panel using dynamic plugin extensions~~ create topology side panel using dynamic plugin extensions

openshift-ci bot added kind/i18n and removed do-not-merge/work-in-progress labels

christianvogt reviewed

View reviewed changes

frontend/packages/topology/src/components/side-bar/providers/useDetailsResourceLink.tsx Outdated

Comment on lines 17 to 20

Contributor

christianvogt Jun 24, 2021

link function will be called twice on the last match instead of only once.

Contributor Author

sahil143 Jul 2, 2021

yes, this is intentional as we need to find the callback that doesn't return null and undefined and get result from that callback.
Couldn't find a lodash utility that does this.

frontend/packages/topology/src/components/side-bar/components/SideBarHeading.tsx Outdated

Contributor

christianvogt Jun 24, 2021

Is this a WIP for another PR? If so add a comment.

If not, you should make use of the actions extensions to populate a menu.

frontend/packages/topology/src/components/side-bar/components/SideBarHeading.scss Outdated

Contributor

christianvogt Jun 24, 2021

Follow conventions.

frontend/packages/topology/src/components/side-bar/components/SideBarAlerts.tsx Outdated

Contributor

christianvogt Jun 24, 2021

Don't we store these values in user settings for health checks?

frontend/packages/console-dynamic-plugin-sdk/src/extensions/topology-details.ts Outdated

Contributor

christianvogt Jun 24, 2021

Why is this added to the API?
I don't think an alert needs to know when it is dismissed.

frontend/packages/topology/src/components/side-bar/TopologyGroupResourcesPanel.tsx Outdated

Contributor

christianvogt Jun 24, 2021

Why remove the type?

frontend/packages/topology/src/components/side-bar/TopologyGroupResourcesPanel.tsx Outdated

Contributor

christianvogt Jun 24, 2021

keys should be unique

frontend/packages/helm-plugin/src/topology/sidebar/release-panel/tab-sections.tsx Outdated

Contributor

christianvogt Jun 24, 2021

We're going to have a lot of sections.
The first check must be made efficiently to filter out all the sections which do not apply to the given element.
These should not be rendered as a hook.

After successfully passing the check, they should return a component which itself can use hooks within.

frontend/packages/topology/src/components/side-bar/components/SideBarHeading.tsx Outdated

Comment on lines 8 to 12

Contributor

christianvogt Jun 24, 2021

There needs to be a fallback resource link if one is not supplied via extension.

extract the resource and create a ResourceLink
render a non-linkable text based on the element's label

frontend/packages/helm-plugin/console-extensions.json Outdated

Comment on lines 140 to 141

Contributor

christianvogt Jun 24, 2021

Why both before and after properties?

Note that the order in which they are defined should remain in tact so long as they are defined by the same plugin.
Therefore if the helm plugin is contributing all help sections, we should not even need to define the before or after properties.

sahil143 force-pushed the topology-sidepanel branch from bcb77f4 to 7b8963f Compare

July 1, 2021 12:02

rohitkrai03 mentioned this pull request

Use action group extensions for group/submenus and create new action menu components using PF menu #9365

Merged

4 tasks

sahil143 force-pushed the topology-sidepanel branch from 7b8963f to 61ac134 Compare

July 2, 2021 14:02

Contributor

rohitkrai03 commented Jul 2, 2021

/assign

openshift-ci bot assigned rohitkrai03

rohitkrai03 approved these changes

View reviewed changes

Contributor

rohitkrai03 left a comment

/approve

Changes looks good to me. Tested locally. Works as expected.

openshift-ci bot added the approved label

Contributor

rohitkrai03 commented Jul 3, 2021

/lgtm

openshift-ci bot added the lgtm label

Contributor

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments

Contributor

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments

Contributor

openshift-bot commented Jul 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

rohitkrai03 commented Jul 4, 2021 •

edited

Loading

/hold

CI is continuously failing.

openshift-ci bot added the do-not-merge/hold label

sahil143 added 4 commits

July 5, 2021 11:49


          create topology side panel using dynamic plugin extensions

51e529f


          fix i18n errors for helm side panel

79ced27


          rework SideBarTabLoader and Alerts, Add Topology actions

018419c


          use Action menu component from shared

d29c2e2

sahil143 force-pushed the topology-sidepanel branch from 61ac134 to d29c2e2 Compare

July 5, 2021 06:39

openshift-ci bot removed the lgtm label

rohitkrai03 suggested changes

View reviewed changes

frontend/packages/helm-plugin/src/actions/providers.ts Outdated

Comment on lines +34 to +42

+                const { t } = useTranslation();
+                const actions = React.useMemo(
+                  () => [
+                    getHelmUpgradeAction(scope, t),
+                    getHelmRollbackAction(scope, t),
+                    getHelmDeleteAction(scope, t),
+                  ],
+                  [scope, t],
+                );

Contributor

rohitkrai03 Jul 5, 2021

We can actually re use the original provider.

Suggested change

      
              const { t } = useTranslation();
          
              const actions = React.useMemo(
          
                () => [
          
                  getHelmUpgradeAction(scope, t),
          
                  getHelmRollbackAction(scope, t),
          
                  getHelmDeleteAction(scope, t),
          
                ],
          
                [scope, t],
          
              );
          
              const actions = useHelmActionProvider(scope);

Contributor Author

sahil143 Jul 5, 2021

@rohitkrai03 fixed!

openshift-ci bot removed the approved label


          update topologyHelmActionProvider to use helm action provider

957f189

rohitkrai03 approved these changes

View reviewed changes

Contributor

rohitkrai03 left a comment

/lgtm
/approve

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented Jul 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/console-dynamic-plugin-sdk/OWNERS~~ [rohitkrai03]
~~frontend/packages/helm-plugin/OWNERS~~ [rohitkrai03]
~~frontend/packages/topology/OWNERS~~ [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

Contributor Author

sahil143 commented Jul 6, 2021

/retest

debsmita1 mentioned this pull request

Migrate Helm actions on topology to use the new extensions #9313

Merged

Contributor Author

sahil143 commented Jul 7, 2021

/retest

Contributor

rohitkrai03 commented Jul 7, 2021

/hold cancel

openshift-ci bot removed the do-not-merge/hold label

openshift-merge-robot merged commit d5d65d4 into openshift:master

spadgett added this to the v4.9 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 Awaiting requested review from jeff-phillips-18

kyoto Awaiting requested review from kyoto

2 more reviewers

christianvogt christianvogt left review comments

rohitkrai03 rohitkrai03 approved these changes

Labels

approved component/dev-console component/helm component/sdk component/shared component/topology kind/i18n lgtm