Use action group extensions for group/submenus and create new action menu components using PF menu#9365
Conversation
beaf649 to
7d3679f
Compare
7d3679f to
2e4bc36
Compare
|
/assign @christianvogt |
sahil143
left a comment
There was a problem hiding this comment.
Looks Good to me.
Tested Locally and works as expected.
I only see one issue with the component is that clicking on subgroup closes the dropdown and action is not performed.
822d0b8 to
7814209
Compare
|
@sahil143 Deleted the dummy commit. The issue with sub menu clicks is because of popper rendering popper as submenus. Since there are no actual use cases for submenus right now, we'll wait for this PF fix - patternfly/patternfly-react#5789. Once the PF fix is in we can update our code to use PF |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes:
Analysis / Root cause:
ActionGroupextension was not used to create groups and submenus in kebab.KebabMenu.Solution Description:
ActionLoaderthat usesActionGroupextensions to create menu options with groups and submenus.ActionMenucomponents that uses PF menu components. Had to use custom menu and submenu rendering logic due to PF bug with submenus.insertBeforeandinsertAfterproperties.ActionMenucomponent now supports both kebab as well as dropdown variant that can be used for different action menu scenarios.ActionsLoader.Screen shots / Gifs for design review:
Screen.Recording.2021-06-29.at.3.06.38.AM.mov
Unit test coverage report:
Screen.Recording.2021-06-29.at.9.58.12.PM.mov
Test setup:
Browser conformance: