Skip to content

add explanation of extended-platform-tests#183

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
deads2k:extended-platform-tests
Jan 22, 2020
Merged

add explanation of extended-platform-tests#183
openshift-merge-robot merged 1 commit into
openshift:masterfrom
deads2k:extended-platform-tests

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Jan 21, 2020

Explain how a testing repo can be a good intermediate step between where we are and where we'd like to be that allows QE to land tests without risking our ability to quickly update levels of kube.

@sttts @mfojtik @soltysh @derekwaynecarr @smarterclayton @jianzhangbjz

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2020
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jan 22, 2020

Nothing to add.

lgtm. Giving time for some more eyes.

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Jan 22, 2020

/lgtm
/hold

so @soltysh can have a look.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 22, 2020
Copy link
Copy Markdown

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [deads2k,mfojtik,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5e0202d into openshift:master Jan 22, 2020
Instead of creating mechanisms to allow this that require modification of critical release templates,
we can instead use the same technique used to create release payloads.

Every team that wants to contribute to the universal set of tests can do so by creating an image that has an entrypoint
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need a way to also have the test run output the location for bugs and contacts for build-cop. If these are blocking we need escalation points IMO.

which conforms to the `openshift-tests` CLI definition.
1. run-test with dry-run
2. run with dry-run and a common set of defined buckets. Help lists which buckets are there.
Based on that information it is possible to layer all the binaries into a single image with a new entry point that
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k would DPTP own this new controller that would layer the test binaries?

/cc @jupierce

@smarterclayton
Copy link
Copy Markdown
Contributor

This is not in implementable yet, still reviewing. This is only in proposed

@jianzhangbjz
Copy link
Copy Markdown

Thanks! /lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants