Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

OCP-24818 Checking OLM descriptors#14

Merged
jianzhangbjz merged 5 commits into
openshift:masterfrom
tbuskey:OCP-24818
Mar 20, 2020
Merged

OCP-24818 Checking OLM descriptors#14
jianzhangbjz merged 5 commits into
openshift:masterfrom
tbuskey:OCP-24818

Conversation

@tbuskey
Copy link
Copy Markdown
Contributor

@tbuskey tbuskey commented Feb 18, 2020

oc explain for InstallPlan, ClusterServiceVersion, Subscription, CatalogSource, OperatorSource, OperatorGroup, PackageManifest, CatalogSourceConfig should not be empty

Test case: https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-24818

Succeeds on OCP 4.4, fails 5(?) on OCP 4.3

If any one of the descriptors is empty, the tests fails and logs the ones that failed and a total count
./extended-platform-tests run all --dry-run | grep 'Checking OLM descriptors' | ./extended-platform-tests run -f - 2>&1 > tee testrun
testrun-24818.log

…cription,CatalogSource,OperatorSource,OperatorGroup,PackageManifest,CatalogSourceConfig
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tbuskey
To complete the pull request process, please assign shawn-hurley
You can assign the PR to them by writing /assign @shawn-hurley in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tbuskey
Copy link
Copy Markdown
Contributor Author

tbuskey commented Feb 18, 2020

/cc @jianzhangbjz, @bandrade, @scolange, @kuiwang02, @mffiedler Have a review

Copy link
Copy Markdown

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments - thanks!

Comment thread test/extended/operators/olm.go Outdated

// OCP-24818 - Checking OLM descriptors
// author: tbuskey@redhat.com
g.It("Checking OLM descriptors", func() {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being done for all CRDs shipped with OpenShift?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianzhangbjz Do you have direction here?

Copy link
Copy Markdown

@awgreene awgreene Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems extremely similar to those featured in openshift/origin#22696 as well. Could you explain how the tests featured in openshift/origin are different from those featured in the openshift/openshift-test repository?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were directed to move QE OLM tests out of the origin repo to this one.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay - that's good to know - thanks!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we're migrating the extended tests from origin to this repo. Details in: openshift/enhancements#183

@awgreene
Copy link
Copy Markdown

Succeeds on OCP 4.4, fails 5(?) on OCP 4.3

@tbuskey this will continue to fail on 4.3 until operator-framework/operator-lifecycle-manager#1197 is merged

@tbuskey
Copy link
Copy Markdown
Contributor Author

tbuskey commented Feb 18, 2020

@awgreene Yes, this fails on 4.3, but it demonstrates the log output.

@tbuskey
Copy link
Copy Markdown
Contributor Author

tbuskey commented Feb 18, 2020

Removed CatalogSourceConfig check

@jianzhangbjz jianzhangbjz merged commit 4d8ebb4 into openshift:master Mar 20, 2020
@tbuskey tbuskey deleted the OCP-24818 branch March 23, 2020 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants