[release-4.3] Bug 1780378: Implement Structural Schema for CRDs by awgreene · Pull Request #1197 · operator-framework/operator-lifecycle-manager

awgreene · 2019-12-13T12:15:10Z

oc explain recently broke when OLM was rebased on top of version 1.16 of Kubernetes. This is due to the introduction of [CRDs Structural Schemas]([1] https://kubernetes.io/blog/2019/06/20/crd-structural-schema/). This PR updates OLMs CustomResourceDefinitions to include a structural schema.

openshift-ci-robot · 2019-12-13T12:15:14Z

@awgreene: This pull request references Bugzilla bug 1780378, which is invalid:

expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1780378: Implement Structural Schema for CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell · 2019-12-13T16:14:07Z

/lgtm

ecordell · 2019-12-13T16:21:21Z

/bugzilla refresh

openshift-ci-robot · 2019-12-13T16:21:28Z

@ecordell: This pull request references Bugzilla bug 1780378, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell · 2019-12-13T17:18:54Z

/hold

ecordell · 2019-12-20T21:24:51Z

@awgreene IIRC, we just need to include the v1alpha2 OperatorGroup version and this is good to go

awgreene · 2020-01-23T22:24:17Z

/retest

awgreene · 2020-02-02T18:05:42Z

@ecordell Regarding your comment:

@awgreene IIRC, we just need to include the v1alpha2 OperatorGroup version and this is good to go

This is a backport of a solution, should I create a new Bugzilla to add support for v1alpha2 to both 4.4 and 4.3? If so - could this PR be merged now or we could update it once the feature is implemented in 4.4.

ecordell · 2020-02-04T13:39:01Z

/bugzilla refresh

openshift-ci-robot · 2020-02-04T13:39:06Z

@ecordell: This pull request references Bugzilla bug 1780378, which is invalid:

expected dependent Bugzilla bug 1769003 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1798051 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2020-02-20T14:47:29Z

/bugzilla refresh

openshift-ci-robot · 2020-02-20T14:47:34Z

@awgreene: This pull request references Bugzilla bug 1780378, which is invalid:

expected dependent Bugzilla bug 1769003 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1798051 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This commit introduces a series of changes which will enable OLM to implement Strucutral Schemas for its CRDs.

This commit updates OLM's Makefile to use the controller-gen tool to generate the structural schemas for its CRDs.

This commit updates the CRDs defined in the manifest dir to include a Structural Schema.

The v1alpha2 version of the operatorgroup crd in the 4.4 OpenShift release was not properly deprecated. Adding back that version to the crd spc.

dinhxuanvu · 2020-02-20T21:19:11Z

/retest

awgreene · 2020-02-21T14:43:05Z

/retest

awgreene · 2020-02-21T16:15:45Z

/bugzilla refresh

openshift-ci-robot · 2020-02-21T16:15:49Z

@awgreene: This pull request references Bugzilla bug 1780378, which is invalid:

expected dependent Bugzilla bug 1769003 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2020-02-24T14:35:59Z

/bugzilla refresh

awgreene · 2020-02-24T14:37:17Z

/bugzilla refresh

openshift-ci-robot · 2020-02-24T14:37:23Z

@awgreene: This pull request references Bugzilla bug 1780378, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-24T14:38:06Z

@awgreene: This pull request references Bugzilla bug 1780378, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

exdx · 2020-02-24T14:44:55Z

/lgtm

openshift-ci-robot · 2020-02-24T14:51:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ecordell · 2020-02-24T16:26:35Z

/hold cancel

awgreene · 2020-02-26T19:10:24Z

@knobunc could you please consider applying the cherry-pick approved label to this PR?

Without this PR:

OLM's CRDs are structures blobs, which introduces security concerns.
CSVs created on a 4.3 cluster may fail validation once this PR is merged. It would be best to introduce this change as quickly as possible to affect as few operators as possible.

openshift-bot · 2020-02-26T22:02:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-26T23:20:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-27T00:51:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-27T01:04:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-27T02:19:22Z

@awgreene: All pull requests linked via external trackers have merged. Bugzilla bug 1780378 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1780378: Implement Structural Schema for CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 13, 2019

openshift-ci-robot requested review from ecordell and njhale December 13, 2019 12:15

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 13, 2019

awgreene changed the title ~~Bug 1780378: Implement Structural Schema for CRDs~~ [release-4.3] Bug 1780378: Implement Structural Schema for CRDs Dec 13, 2019

openshift-ci-robot assigned ecordell Dec 13, 2019

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 13, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 13, 2019

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 13, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2019

awgreene force-pushed the backport-structural-schema branch from 297050d to 75fb78f Compare December 26, 2019 08:15

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 26, 2019

openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 4, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 4, 2020

awgreene mentioned this pull request Feb 18, 2020

OCP-24818 Checking OLM descriptors openshift/openshift-tests#14

Merged

awgreene added 3 commits February 20, 2020 15:48

Update CRD go types

895866a

This commit introduces a series of changes which will enable OLM to implement Strucutral Schemas for its CRDs.

Implement controller-gen

de4c8e1

This commit updates OLM's Makefile to use the controller-gen tool to generate the structural schemas for its CRDs.

Update manifest CRDs

bc1f231

This commit updates the CRDs defined in the manifest dir to include a Structural Schema.

awgreene force-pushed the backport-structural-schema branch from ef5c38c to fd7b5ab Compare February 20, 2020 20:49

Reinstate v1alpha2 operatorgroup

4e5ffba

The v1alpha2 version of the operatorgroup crd in the 4.4 OpenShift release was not properly deprecated. Adding back that version to the crd spc.

awgreene force-pushed the backport-structural-schema branch from fd7b5ab to 4e5ffba Compare February 20, 2020 20:58

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 24, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 24, 2020

openshift-ci-robot assigned exdx Feb 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020

eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 26, 2020

openshift-merge-robot merged commit 93f3461 into operator-framework:release-4.3 Feb 27, 2020

Conversation

awgreene commented Dec 13, 2019

Uh oh!

openshift-ci-robot commented Dec 13, 2019

Uh oh!

ecordell commented Dec 13, 2019

Uh oh!

ecordell commented Dec 13, 2019

Uh oh!

openshift-ci-robot commented Dec 13, 2019

Uh oh!

ecordell commented Dec 13, 2019

Uh oh!

ecordell commented Dec 20, 2019

Uh oh!

awgreene commented Jan 23, 2020

Uh oh!

awgreene commented Feb 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ecordell commented Feb 4, 2020

Uh oh!

openshift-ci-robot commented Feb 4, 2020

Uh oh!

awgreene commented Feb 20, 2020

Uh oh!

openshift-ci-robot commented Feb 20, 2020

Uh oh!

dinhxuanvu commented Feb 20, 2020

Uh oh!

awgreene commented Feb 21, 2020

Uh oh!

awgreene commented Feb 21, 2020

Uh oh!

openshift-ci-robot commented Feb 21, 2020

Uh oh!

awgreene commented Feb 24, 2020

Uh oh!

awgreene commented Feb 24, 2020

Uh oh!

openshift-ci-robot commented Feb 24, 2020

Uh oh!

openshift-ci-robot commented Feb 24, 2020

Uh oh!

exdx commented Feb 24, 2020

Uh oh!

openshift-ci-robot commented Feb 24, 2020

Uh oh!

ecordell commented Feb 24, 2020

Uh oh!

awgreene commented Feb 26, 2020

Uh oh!

openshift-bot commented Feb 26, 2020

Uh oh!

openshift-bot commented Feb 26, 2020

Uh oh!

openshift-bot commented Feb 27, 2020

Uh oh!

openshift-bot commented Feb 27, 2020

Uh oh!

openshift-ci-robot commented Feb 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

awgreene commented Feb 2, 2020 •

edited

Loading