MachinePool: hack name of vSphere default worker MachineSet#2057
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
approved
|
/test all |
2uasimojo
force-pushed
the
HIVE-2254/vsphere-mset-suffix
branch
from
29b22f3 to
e7cca8d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2057 +/- ##
=======================================
Coverage 57.38% 57.39%
=======================================
Files 186 186
Lines 25697 25702 +5
=======================================
+ Hits 14747 14752 +5
Misses 9710 9710
Partials 1240 1240
|
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
2uasimojo
force-pushed
the
HIVE-2254/vsphere-mset-suffix
branch
from
e7cca8d to
6fd31c9
Compare
|
/assign @abutcher |
|
NTR: I tested this against 4.12 and 4.13 spokes, with the default worker pool as well as an additional one, with this code against hive master (currently vendoring 4.12 installer code) and on top of #2052 (vendoring recent master installer code). |
abutcher
left a comment
abutcher
left a comment
There was a problem hiding this comment.
One nit on comment, looks good to me
With recent installer changes to accommodate zones in vSphere, the name of the default worker pool in OCP 4.13+ is now suffixed with a `-0` even when only one zone is in play. Hive's day 2 MachinePool logic needs to be able to generate the correct MachineSet name when talking to a 4.13+ cluster -- but also when talking to a 4.12- cluster. This commit adds in a special case to discover and account for this difference where it exists. HIVE-2254
2uasimojo
force-pushed
the
HIVE-2254/vsphere-mset-suffix
branch
from
6fd31c9 to
30afd4b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, abutcher The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick mce-2.3 |
|
@2uasimojo: new pull request created: #2067 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
With recent installer changes to accommodate zones in vSphere, the name of the default worker pool in OCP 4.13+ is now suffixed with a
-0even when only one zone is in play. Hive's day 2 MachinePool logic needs to be able to generate the correct MachineSet name when talking to a 4.13+ cluster -- but also when talking to a 4.12- cluster. This commit adds in a special case to discover and account for this difference where it exists.HIVE-2254