[mce-2.3] MachinePool: hack name of vSphere default worker MachineSet#2067
Conversation
With recent installer changes to accommodate zones in vSphere, the name of the default worker pool in OCP 4.13+ is now suffixed with a `-0` even when only one zone is in play. Hive's day 2 MachinePool logic needs to be able to generate the correct MachineSet name when talking to a 4.13+ cluster -- but also when talking to a 4.12- cluster. This commit adds in a special case to discover and account for this difference where it exists. HIVE-2254
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## mce-2.3 #2067 +/- ##
========================================
Coverage 57.71% 57.72%
========================================
Files 186 186
Lines 25226 25231 +5
========================================
+ Hits 14559 14564 +5
Misses 9428 9428
Partials 1239 1239
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick mce-2.2 |
|
@2uasimojo: new pull request created: #2068 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2057
/assign 2uasimojo
HIVE-2254