Skip to content

HOSTEDCP-1989: Move NTO reconcile logic into their own file#4962

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
enxebre:move-nto
Oct 25, 2024
Merged

HOSTEDCP-1989: Move NTO reconcile logic into their own file#4962
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
enxebre:move-nto

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Oct 22, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 22, 2024 •
edited by openshift-ci Bot
Loading

@enxebre: This pull request references HOSTEDCP-1989 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from csrwng and hasueki October 22, 2024 08:24
@openshift-ci openshift-ci Bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Oct 22, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Oct 22, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 22, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 3be2be2
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/67176129fcc0b700087bd493
😎 Deploy Preview https://deploy-preview-4962--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@muraee
Copy link
Copy Markdown
Contributor

muraee commented Oct 22, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 22, 2024

/retest-required

Remaining retests: 0 against base HEAD 27044d0 and 2 for PR HEAD 3be2be2 in total

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 22, 2024

/test e2e-aws

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 22, 2024

/retest

2 similar comments
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 22, 2024

/retest

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 22, 2024

/retest

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 23, 2024

/test e2e-aks

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 23, 2024

/retest

@openshift-ci openshift-ci Bot added the area/testing Indicates the PR includes changes for e2e testing label Oct 24, 2024
@Patryk-Stefanski
Copy link
Copy Markdown
Contributor

Patryk-Stefanski commented Oct 24, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 24, 2024

/retest-required

Remaining retests: 0 against base HEAD 2dccab2 and 2 for PR HEAD b87045f in total

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 24, 2024

wants to #4973 to eliminate the flake

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 25, 2024

/retest

@muraee
Copy link
Copy Markdown
Contributor

muraee commented Oct 25, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 25, 2024

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2024

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 5540a7f into openshift:main Oct 25, 2024
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Oct 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202410251810.p0.g5540a7f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@hasueki hasueki Awaiting requested review from hasueki

Assignees

@muraee muraee

@Patryk-Stefanski Patryk-Stefanski

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@enxebre @openshift-ci-robot @muraee @Patryk-Stefanski @openshift-bot