OCPBUGS-43756: update eventuallyDaemonSetRollsOut to only watch ready…

[Patryk-Stefanski]

… pods

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-43756, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

… pods

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Patryk-Stefanski]

/test e2e-aks

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[Patryk-Stefanski]

/jira refresh

[openshift-ci-robot]

@Patryk-Stefanski: This pull request references Jira Issue OCPBUGS-43756, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sjenning]

/approve
/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2dccab2 and 2 for PR HEAD 137edf8 in total

[Patryk-Stefanski]

/hold

[enxebre]

As discussed offline It makes no sense for rollout tests to only wait for nodes to be ready because you are not actually waiting for the rollout to finish. As soon as the first Node rollsout and go ready the check will return true.
Instead this should gate on something like

			e2eutil.ConditionPredicate[*hyperv1.NodePool](e2eutil.Condition{
				Type:   hyperv1.NodePoolUpdatingVersionConditionType,
				Status: metav1.true,
			}),
And then
			e2eutil.ConditionPredicate[*hyperv1.NodePool](e2eutil.Condition{
				Type:   hyperv1.NodePoolUpdatingVersionConditionType,
				Status: metav1.ConditionFalse,
			}),

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	82e69a0
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/671a255339f3420008f8f3c4
😎 Deploy Preview	https://deploy-preview-4973--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Patryk-Stefanski]

/hold cancel

[enxebre]

Thanks!
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, Patryk-Stefanski, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [enxebre,sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d29e8a1 and 2 for PR HEAD fb04fda in total

[enxebre]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD abd7882 and 2 for PR HEAD f0d1bfd in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD abd7882 and 2 for PR HEAD f0d1bfd in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9a219d8 and 2 for PR HEAD f0d1bfd in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9a219d8 and 2 for PR HEAD f0d1bfd in total

[openshift-ci]

@Patryk-Stefanski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[enxebre]

/lgtm

[openshift-ci-robot]

@Patryk-Stefanski: Jira Issue OCPBUGS-43756: All pull requests linked via external trackers have merged:

• openshift/hypershift#4973

Jira Issue OCPBUGS-43756 has been moved to the MODIFIED state.

Details

In response to this:

… pods

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.