Skip to content

Bug 1820633: [release-4.4] Gather image config#101

Closed
mfojtik wants to merge 28 commits intoopenshift:masterfrom
mfojtik:gather-image-44
Closed

Bug 1820633: [release-4.4] Gather image config#101
mfojtik wants to merge 28 commits intoopenshift:masterfrom
mfojtik:gather-image-44

Conversation

@mfojtik
Copy link
Copy Markdown
Contributor

@mfojtik mfojtik commented May 11, 2020

This picks #100 on top of the refactoring changes.

This is needed so the changes from master are still pickable to release-4.4.

/cc @iNecas @martinkunc

smarterclayton and others added 28 commits February 21, 2020 10:07
@smarterclayton
manifests: Remove run-level, insights operator does not need it
385fefc 
Insights should follow normal admission control rules for a cluster.
@openshift-merge-robot
Merge pull request openshift#79 from openshift-cherrypick-robot/cherr…
c69cd18 
…y-pick-78-to-release-4.4

Bug 1805917: Insights operator does not require being in an openshift run-level to function
@martinkunc
Cherrypick 6d35d54 Support for specific http proxy for the service
85f4858
@martinkunc
Cherrypick f77afd7 Updating vendor folder
400c51c
@martinkunc
Cherrypick c503b45 Unit tests for specific proxy settings
f77d88a
@martinkunc
Cherrypick 6085bea Report logs when checkPods is going to fail
c897e5d
@martinkunc
Cherrypick 0ba3f7b Rise the timeouts
bbe0a5b
@martinkunc
Cherrypick d4605f1 More increased timeouts
622a9a1
@martinkunc
Cherrypick 147dca3 Remove commented code block - moved above.
9063ef7
@martinkunc
Cherrypick d19d8d8 Moving specific proxy to authorizer
1816554
@martinkunc
Cherrypick 65e2183 Support for specific http proxy for the service
46cb2fe
@martinkunc
Updating go.sum
38bfdcb
@openshift-merge-robot
Merge pull request openshift#89 from martinkunc/release-4.4
9d96623 
Bug 1820633: Cherry-pick release 4.4 Support for specific http proxy for the service
@martinkunc @mfojtik
Fix reporting duration error and add tests
4c10328
@martinkunc @mfojtik
Minor refactoring
a82d17d
@martinkunc @mfojtik
Remove comment
b0fb65c
@martinkunc @mfojtik
Add test to obseve config changes
c5bd092
@martinkunc @mfojtik
Collect certificates
240ab3d
@martinkunc @mfojtik
Incorporate comments + make for lint/vet
1cc5622
@martinkunc @mfojtik
Add logging
75da421
@martinkunc @mfojtik
Don't store approved certificates
d6386f8
@martinkunc @mfojtik
WIP: Collecting config maps
bb71f3f
@martinkunc @mfojtik
Use more obvious anonymized PEM block token
dc6fc97
@martinkunc @mfojtik
Gather BinaryData ConfigMap encoded in base64.
16b7b88 
Add tests for for configmaps anonymizer
@martinkunc @mfojtik
Increase tests timeout and ignore failing tests
0cc1466 
Ignore failing unit test
@martinkunc @mfojtik
Refactoring collector, add Doc and doc generator
613d49e
@mfojtik
gather: grab config.imageregistry.operator.openshift.io/cluster
3f879b5
@mfojtik
bump(*): get openshift/client-go for image registry
f1ae0f4
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020
@martinkunc
Copy link
Copy Markdown
Contributor

martinkunc commented May 11, 2020

Hi @mfojtik and sorry for the mess. Let me please understand. You basically merged all in 4.4 to allow future automated cherry-picks ? I think I would need to do the same for old releases as well.

@martinkunc
Copy link
Copy Markdown
Contributor

martinkunc commented May 11, 2020

The CLs looks good as far as I can say. It includes some changes from #96, which is still pending because of freeze in 4.4., but I think it wont cause anything bad.
It would require adding BZ case, which would target 4.4.z release, so I guess it would still be hold to merge unless I am missing something.

@martinkunc
Copy link
Copy Markdown
Contributor

martinkunc commented May 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkunc, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@martinkunc
Copy link
Copy Markdown
Contributor

martinkunc commented May 12, 2020

/retitle Bug 1820633: [release-4.4] Gather image config

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Gather image config Bug 1820633: [release-4.4] Gather image config May 12, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 12, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 12, 2020

@mfojtik: This pull request references Bugzilla bug 1820633, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.5.0" release, but it targets "4.4.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1820633: [release-4.4] Gather image config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martinkunc
Copy link
Copy Markdown
Contributor

martinkunc commented May 12, 2020

Oh wait, you are merging this to master ? Shouldn't it be to release-4.4 branch ?
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2020
@mfojtik mfojtik closed this May 12, 2020
@martinkunc martinkunc mentioned this pull request May 21, 2020
Merged
@martinkunc martinkunc mentioned this pull request May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iNecas iNecas Awaiting requested review from iNecas

@martinkunc martinkunc Awaiting requested review from martinkunc

Assignees

@martinkunc martinkunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mfojtik @martinkunc @openshift-ci-robot @smarterclayton @openshift-merge-robot