Bug 1820633: Cherry-pick release 4.4 Support for specific http proxy for the service by martinkunc · Pull Request #89 · openshift/insights-operator

martinkunc · 2020-04-03T05:57:48Z

Cherry-pick support for specific http proxy
Obviously I wasn't successful with squashing the commits here, so I had to cherry pick them manually this time.

openshift-ci-robot · 2020-04-03T05:57:49Z

@martinkunc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Release 4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-03T06:02:13Z

@martinkunc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Release 4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-04-03T11:40:49Z

It seems to me that there's more code than it supposed to be, is this correct?

If you try to apply the patch directly does it work?

Also, the title of this PR is misleading, we are backporting proxy to 4.4.

martinkunc · 2020-04-03T11:44:43Z

/retest

openshift-ci-robot · 2020-04-03T12:47:29Z

@martinkunc: This pull request references Bugzilla bug 1820595, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1820595 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1820595: Support for specific http proxy for the service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-04-03T12:49:01Z

/bugzilla refresh

openshift-ci-robot · 2020-04-03T12:49:03Z

@martinkunc: This pull request references Bugzilla bug 1820595, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1820595 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-04-03T12:53:08Z

/bugzilla refresh

openshift-ci-robot · 2020-04-03T12:53:10Z

@martinkunc: This pull request references Bugzilla bug 1820595, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.3.z" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1820595 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-03T13:40:06Z

@martinkunc: This pull request references Bugzilla bug 1820633, which is invalid:

expected dependent Bugzilla bug 1820595 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
expected dependent Bugzilla bug 1820595 to target the "4.5.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1820633: Cherry-pick release 4.4 Support for specific http proxy for the service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-04-03T13:43:44Z

/retest

martinkunc · 2020-04-03T13:44:00Z

/bugzilla refresh

openshift-ci-robot · 2020-04-03T13:44:03Z

@martinkunc: This pull request references Bugzilla bug 1820633, which is invalid:

expected dependent Bugzilla bug 1820595 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-04-06T11:00:46Z

/bugzilla refresh

iNecas · 2020-04-06T11:40:51Z

/lgtm

martinkunc · 2020-04-07T06:05:45Z

@jwforres Could I ask for approving the cherry-pick with cherry-pick-approved label please ?

openshift-bot · 2020-04-09T16:01:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T16:14:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T18:11:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-09T19:03:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

eparis · 2020-04-09T19:10:56Z

/lgtm cancel
why are the insights test failing? seems that needs to be addressed.

eparis · 2020-04-11T22:40:05Z

/test ci/prow/insights-operator-e2e-tests

openshift-ci-robot · 2020-04-11T22:40:28Z

@eparis: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test e2e-aws
/test e2e-aws-upgrade
/test images
/test insights-operator-e2e-tests
/test unit

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/insights-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eparis · 2020-04-11T22:40:51Z

/test insights-operator-e2e-tests

eparis · 2020-04-13T13:05:19Z

So far I see base_test.go failing 4 times in the history and passing 3 times. how are things in master? Is your flake rate 50% there?

/test insights-operator-e2e-tests

martinkunc · 2020-04-14T11:33:36Z

@eparis We have the same situation in master with this test. I already have an internal case to investigate it.

alexandrevicenzi · 2020-04-16T07:33:07Z

/lgtm

openshift-ci-robot · 2020-04-16T07:33:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandrevicenzi, iNecas, martinkunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [alexandrevicenzi,iNecas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alexandrevicenzi · 2020-04-16T07:34:18Z

/test insights-operator-e2e-tests

nee1esh · 2020-04-16T14:29:10Z

/retest

martinkunc · 2020-04-16T19:12:17Z

/retest

openshift-bot · 2020-04-17T05:57:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-17T08:34:38Z

@martinkunc: All pull requests linked via external trackers have merged: openshift/insights-operator#89. Bugzilla bug 1820633 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1820633: Cherry-pick release 4.4 Support for specific http proxy for the service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc added 10 commits April 3, 2020 07:52

Cherrypick 6d35d54 Support for specific http proxy for the service

85f4858

Cherrypick f77afd7 Updating vendor folder

400c51c

Cherrypick c503b45 Unit tests for specific proxy settings

f77d88a

Cherrypick 6085bea Report logs when checkPods is going to fail

c897e5d

Cherrypick 0ba3f7b Rise the timeouts

bbe0a5b

Cherrypick d4605f1 More increased timeouts

622a9a1

Cherrypick 147dca3 Remove commented code block - moved above.

9063ef7

Cherrypick d19d8d8 Moving specific proxy to authorizer

1816554

Cherrypick 65e2183 Support for specific http proxy for the service

46cb2fe

Updating go.sum

38bfdcb

openshift-ci-robot requested review from derekwaynecarr and smarterclayton April 3, 2020 05:58

martinkunc changed the title ~~Release 4.4~~ Bug 1820595: Support for specific http proxy for the service Apr 3, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 3, 2020

martinkunc changed the title ~~Bug 1820595: Support for specific http proxy for the service~~ Bug 1820595: Cherry-pick release 4.4 Support for specific http proxy for the service Apr 3, 2020

martinkunc changed the title ~~Bug 1820595: Cherry-pick release 4.4 Support for specific http proxy for the service~~ Bug 1820633: Cherry-pick release 4.4 Support for specific http proxy for the service Apr 3, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 6, 2020

openshift-ci-robot assigned iNecas Apr 6, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2020

martinkunc mentioned this pull request Apr 7, 2020

Bug 1821149: Cherry-pick release 4.3 Support for specific http proxy for the service #91

Merged

derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2020

openshift-ci-robot assigned eparis Apr 9, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020

openshift-ci-robot assigned alexandrevicenzi Apr 16, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020

openshift-merge-robot merged commit 9d96623 into openshift:release-4.4 Apr 17, 2020

Conversation

martinkunc commented Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 3, 2020

Uh oh!

openshift-ci-robot commented Apr 3, 2020

Uh oh!

alexandrevicenzi commented Apr 3, 2020

Uh oh!

martinkunc commented Apr 3, 2020

Uh oh!

openshift-ci-robot commented Apr 3, 2020

Uh oh!

martinkunc commented Apr 3, 2020

Uh oh!

openshift-ci-robot commented Apr 3, 2020

Uh oh!

martinkunc commented Apr 3, 2020

Uh oh!

openshift-ci-robot commented Apr 3, 2020

Uh oh!

openshift-ci-robot commented Apr 3, 2020

Uh oh!

martinkunc commented Apr 3, 2020

Uh oh!

martinkunc commented Apr 3, 2020

Uh oh!

openshift-ci-robot commented Apr 3, 2020

Uh oh!

martinkunc commented Apr 6, 2020

Uh oh!

iNecas commented Apr 6, 2020

Uh oh!

martinkunc commented Apr 7, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

openshift-bot commented Apr 9, 2020

Uh oh!

eparis commented Apr 9, 2020

Uh oh!

eparis commented Apr 11, 2020

Uh oh!

openshift-ci-robot commented Apr 11, 2020

Uh oh!

eparis commented Apr 11, 2020

Uh oh!

eparis commented Apr 13, 2020

Uh oh!

martinkunc commented Apr 14, 2020

Uh oh!

alexandrevicenzi commented Apr 16, 2020

Uh oh!

openshift-ci-robot commented Apr 16, 2020

Uh oh!

alexandrevicenzi commented Apr 16, 2020

Uh oh!

nee1esh commented Apr 16, 2020

Uh oh!

martinkunc commented Apr 16, 2020

Uh oh!

openshift-bot commented Apr 17, 2020

Uh oh!

openshift-ci-robot commented Apr 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

martinkunc commented Apr 3, 2020 •

edited

Loading