Skip to content

[release-4.3] Bug 1826608: Refactoring collector, add Doc and doc generator#106

Closed
martinkunc wants to merge 34 commits intoopenshift:release-4.3from
martinkunc:release-4-3-add-docs
Closed

[release-4.3] Bug 1826608: Refactoring collector, add Doc and doc generator#106
martinkunc wants to merge 34 commits intoopenshift:release-4.3from
martinkunc:release-4-3-add-docs

Conversation

@martinkunc
Copy link
Copy Markdown
Contributor

@martinkunc martinkunc commented May 13, 2020

This picks #95 and updates dependencies.

martinkunc and others added 30 commits May 13, 2020 06:39
@martinkunc
Cherry-pick 4301a30 added metric status code '0' to indicate failed r…
42fdb21 
…equest builds
@smarterclayton @martinkunc
controller: Update to latest library-go semantics for graceful shutdown
03d193e 
library-go should more correctly handle context termination.
@smarterclayton @martinkunc
gather: Only return pods that have been pending more than 2m
186b188 
We are currently returning all of them and it is confusing.
@martinkunc
Cherry-pick 7788e21 Collect certificates
d07c60b
@martinkunc
Cherry-pick 70e91e5 Incorporate comments + make for lint/vet
57cab2e
@martinkunc
Cherry-pick 6c10612 Add logging
e02405f
@martinkunc
cherry-pick 8cb8576 Don't store approved certificates
b008bf4
@martinkunc
Upgrading go mod
a001b8b
@smarterclayton @martinkunc
Cherry-pick 75f34c7 manifests: Remove run-level, insights operator do…
613e0cd 
…es not need it

Insights should follow normal admission control rules for a cluster.
@martinkunc
cherry-pick a2a28f3 add new test TestClusterDefaultNodeSelector
f6c2e20
@martinkunc
Cherry-pick ff66712 add coverage for BZ1753755
d4f09f0
@martinkunc
Fix reporting duration error and add tests
1131e8e
@martinkunc
Cherry-pick 4014103 Add kubernetes fake
2645849
@martinkunc
Minor refactoring
ae80a19
@martinkunc
Remove comment
ad65e4b
@martinkunc
Add test to obseve config changes
64323e4
@martinkunc
WIP: Collecting config maps
f0101e3
@martinkunc
Cherry-pick 6d35d54 Support for specific http proxy for the service
fabe0d6
@martinkunc
Cherry-pick f77afd7 Updating vendor folder
65e8424
@martinkunc
Cherry-pick c503b45 Unit tests for specific proxy settings
fd505de
@martinkunc
Report logs when checkPods is going to fail
aecb9aa
@martinkunc
Rise the timeouts
3a149b3
@martinkunc
Cherry-pick d4605f1 More increased timeouts
8e36de1
@martinkunc
Remove commented code block - moved above.
da8ec6c
@martinkunc
Use more obvious anonymized PEM block token
72297ed
@martinkunc
Cherry-pick d19d8d8 Moving specific proxy to authorizer
352551e
@martinkunc
Cherry-pick 65e2183 Support for specific http proxy for the service
0d90e35
@martinkunc
Specify bugzilla component in OWNERS
200f300
@martinkunc
Gather BinaryData ConfigMap encoded in base64.
048486a 
Add tests for for configmaps anonymizer
@martinkunc
Updating go modules
8e471ec
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 13, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 13, 2020

@martinkunc: This pull request references Bugzilla bug 1826608, which is invalid:

  • expected dependent Bugzilla bug 1826607 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1826608: Refactoring collector, add Doc and doc generator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tisnik
tisnik approved these changes May 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @martinkunc

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkunc, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented May 28, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 28, 2020

@martinkunc: This pull request references Bugzilla bug 1826608, which is invalid:

  • expected dependent Bugzilla bug 1834677 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1826607 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (DUPLICATE) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 30, 2020

The refactoring change was merged in scope of #111

The Doc + generator will be only merged to 4.4

@martinkunc martinkunc closed this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

1 more reviewer

@tisnik tisnik tisnik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martinkunc @openshift-ci-robot @tisnik @smarterclayton