Skip to content

[release-4.3] Bug 1836815: Gather image registry config#111

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.3from
martinkunc:release-4-3-gather-image-registry-config
Sep 30, 2020
Merged

[release-4.3] Bug 1836815: Gather image registry config#111
openshift-merge-robot merged 2 commits intoopenshift:release-4.3from
martinkunc:release-4-3-gather-image-registry-config

Conversation

@martinkunc
Copy link
Copy Markdown
Contributor

@martinkunc martinkunc commented May 18, 2020

Picks #103 and updates dependencies

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 18, 2020

@martinkunc: This pull request references Bugzilla bug 1836815, which is invalid:

  • expected dependent Bugzilla bug 1832232 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1834677 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1832232 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1836815: Gather image registry config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2020
tisnik
tisnik approved these changes Jul 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it is huge :) But it looks ok to me.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 22, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 22, 2020

@martinkunc: This pull request references Bugzilla bug 1836815, which is invalid:

  • expected dependent Bugzilla bug 1832232 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 22, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 22, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 22, 2020

@martinkunc: This pull request references Bugzilla bug 1836815, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1834677 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1834677 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 22, 2020
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 22, 2020 •
edited
Loading

Release managers: The change list is huge, but this is neccessary to bring in the refactoring which happened in 4.5 and 4.4 + take all the missing commits from 4.5 together.
The future changes are using infrastructure of this refactored code, so they will build on this.

natiiix
natiiix approved these changes Sep 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Obligatory "I didn't go through the changes line by line"

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 24, 2020

@markmc Apologise for direct ping, but could you please grant cherry-pick-approved to this PR ? It is collection of changes after refactoring including Adding collection to image registry in the insights operator. We had similar big CLs coming to 4.4 and 4.5 and by merging this, we could easily merge changes coming from latest versions, which includes this refactoring. We still have changes required to be merged to 4.3 unfortunately.
Thank you!

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 24, 2020
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 25, 2020

/retest

1 similar comment
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 25, 2020

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 29, 2020
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 30, 2020

/retest

@martinkunc martinkunc force-pushed the release-4-3-gather-image-registry-config branch from 4278b0c to 7463644 Compare September 30, 2020 05:54
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 30, 2020

/test unit

1 similar comment
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Sep 30, 2020

/test unit

@tremes
Copy link
Copy Markdown
Contributor

tremes commented Sep 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkunc, natiiix, tisnik, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 50ccfeb into openshift:release-4.3 Sep 30, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 30, 2020

@martinkunc: All pull requests linked via external trackers have merged:

Bugzilla bug 1836815 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1836815: Gather image registry config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martinkunc martinkunc mentioned this pull request Sep 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

2 more reviewers

@tisnik tisnik tisnik approved these changes

@natiiix natiiix natiiix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tremes tremes

@natiiix natiiix

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@martinkunc @openshift-ci-robot @openshift-bot @tremes @tisnik @natiiix @markmc @openshift-merge-robot