[release-4.4] Bug 1834677: Gather image registry config by mfojtik · Pull Request #103 · openshift/insights-operator

mfojtik · 2020-05-12T08:07:30Z

This picks #100 on top of the refactoring changes.

This is needed so the changes from master are still pickable to release-4.4.

Add tests for for configmaps anonymizer

Ignore failing unit test

openshift-ci-robot · 2020-05-12T08:07:31Z

@mfojtik: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.4] Gather image registry config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-12T08:08:03Z

@mfojtik: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.4] Gather image registry config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-12T08:11:08Z

@mfojtik: This pull request references Bugzilla bug 1834677, which is invalid:

expected dependent Bugzilla bug 1832232 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1834677: Gather image registry config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-05-12T08:11:20Z

/bugzilla refresh

openshift-ci-robot · 2020-05-12T08:11:23Z

@mfojtik: This pull request references Bugzilla bug 1834677, which is invalid:

expected dependent Bugzilla bug 1832232 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-05-12T08:14:32Z

I think it should be this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1834629
That is what I created from yours for backport to 4.4

mfojtik · 2020-05-12T08:17:42Z

@martinkunc i accidentally created new one and closed yours as dupe...

martinkunc · 2020-05-12T08:19:12Z

ok, sorry

iNecas · 2020-05-12T10:33:35Z

Seems like the test failure is relevant?

martinkunc · 2020-05-12T10:43:26Z

/test insights-operator-e2e-tests

openshift-ci-robot · 2020-05-23T09:37:09Z

@mfojtik: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tisnik

Interesting approach to generate doc :) Thank you @mfojtik

openshift-ci-robot · 2020-05-28T06:01:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mfojtik,tisnik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

martinkunc · 2020-05-28T09:32:48Z

@mfojtik Could you please rebase this one once more ? There should be minimal changes I hope. Thank you!

martinkunc · 2020-06-02T08:23:04Z

@mfojtik Can I fork your changes and prepare a new PR to resolve the conflict ?

martinkunc · 2020-06-29T12:03:07Z

This is being superseeded by #131

sdodson · 2020-07-02T19:20:32Z

/close

openshift-ci-robot · 2020-07-02T19:20:48Z

@sdodson: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc and others added 15 commits May 11, 2020 19:52

Fix reporting duration error and add tests

4c10328

Minor refactoring

a82d17d

Remove comment

b0fb65c

Add test to obseve config changes

c5bd092

Collect certificates

240ab3d

Incorporate comments + make for lint/vet

1cc5622

Add logging

75da421

Don't store approved certificates

d6386f8

WIP: Collecting config maps

bb71f3f

Use more obvious anonymized PEM block token

dc6fc97

Gather BinaryData ConfigMap encoded in base64.

16b7b88

Add tests for for configmaps anonymizer

Increase tests timeout and ignore failing tests

0cc1466

Ignore failing unit test

Refactoring collector, add Doc and doc generator

613d49e

gather: grab config.imageregistry.operator.openshift.io/cluster

3f879b5

bump(*): get openshift/client-go for image registry

f1ae0f4

openshift-ci-robot requested review from smarterclayton and tisnik May 12, 2020 08:07

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020

mfojtik changed the title ~~[release-4.4] Gather image registry config~~ [release-4.4] Bug 1834677: Gather image registry config May 12, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 12, 2020

ricardomaraschini mentioned this pull request May 12, 2020

Bug 1808118: Add OperatorSpec object to image registry config openshift/api#640

Merged

This was referenced May 18, 2020

[release-4.2] Bug 1836816: Gather image registry config #110

Closed

[release-4.3] Bug 1836815: Gather image registry config #111

Merged

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2020

martinkunc mentioned this pull request May 25, 2020

Bug 1837967: Gathering Image Pruner configuration #113

Merged

tisnik approved these changes May 28, 2020

View reviewed changes

martinkunc mentioned this pull request Jun 29, 2020

[release-4.4] Bug 1834677: Gather image registry config (refresh) #131

Merged

openshift-ci-robot closed this Jul 2, 2020

Conversation

mfojtik commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented May 12, 2020

Uh oh!

openshift-ci-robot commented May 12, 2020

Uh oh!

openshift-ci-robot commented May 12, 2020

Uh oh!

mfojtik commented May 12, 2020

Uh oh!

openshift-ci-robot commented May 12, 2020

Uh oh!

martinkunc commented May 12, 2020

Uh oh!

mfojtik commented May 12, 2020

Uh oh!

martinkunc commented May 12, 2020

Uh oh!

iNecas commented May 12, 2020

Uh oh!

martinkunc commented May 12, 2020

Uh oh!

openshift-ci-robot commented May 23, 2020

Uh oh!

tisnik left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented May 28, 2020

Uh oh!

martinkunc commented May 28, 2020

Uh oh!

martinkunc commented Jun 2, 2020

Uh oh!

martinkunc commented Jun 29, 2020

Uh oh!

sdodson commented Jul 2, 2020

Uh oh!

openshift-ci-robot commented Jul 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mfojtik commented May 12, 2020 •

edited

Loading