[release-4.4] Bug 1834677: Gather image registry config (refresh)

[martinkunc]

This picks #100 on top of the refactoring changes and superseeds #103

This is needed so the changes from master are still pickable to release-4.4.

/cc @mfojtik

[openshift-ci-robot]

@martinkunc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Gather image registry into 4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[martinkunc]

/retitle [release-4.4] Bug 1834677: Gather image registry config (refresh)

[openshift-ci-robot]

@martinkunc: This pull request references Bugzilla bug 1834677, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.4.z) matches configured target release for branch (4.4.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1832232 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1832232 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
• bug has dependents

Details

In response to this:

[release-4.4] Bug 1834677: Gather image registry config (refresh)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[martinkunc]

/test insights-operator-e2e-tests

[iNecas]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iNecas, martinkunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [iNecas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sdodson]

Is this another of the big cleanup efforts? I'm surprised by how many commits there are, many of them look like they're cleaning up interim state. If this is a clean pick from already merged commits upstream that's fine but in the future lets make sure that we don't have interim commits that produce broken state.

See https://github.com/openshift/enhancements/blob/master/guidelines/commit_and_pr_text.md#number-of-commits

[martinkunc]

/test images
/test e2e-aws
/test insights-operator-e2e-tests
/test e2e-aws-upgrade

[martinkunc]

Is this another of the big cleanup efforts? I'm surprised by how many commits there are, many of them look like they're cleaning up interim state. If this is a clean pick from already merged commits upstream that's fine but in the future lets make sure that we don't have interim commits that produce broken state.

See https://github.com/openshift/enhancements/blob/master/guidelines/commit_and_pr_text.md#number-of-commits

@sdodson This is indeed one. We did some refactoring, plus had some missing commits in past on which this PR depends. Resovling it now would help us automate the merges much more often. I will try to limit the number of commits in the future.

[martinkunc]

/test e2e-aws

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@martinkunc: All pull requests linked via external trackers have merged: openshift/insights-operator#131. Bugzilla bug 1834677 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1834677: Gather image registry config (refresh)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.