CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes by tthvo · Pull Request #10132 · openshift/installer

tthvo · 2025-11-26T18:36:42Z

Descriptions

GP3 volumes have the ability to configure throughput from 125 MiB/s to 2000 MiB/s. This allows the ability to set this at install time in the install-config.

This is a take-2 of #9945 after it was reverted in #10131 due to aws serial test failure.

Notes

The following new changes are introduced:

The throughput field is now a int32 pointer to match openshift/api. It does break the convention with iops, but at least it gives us an option to represent specified vs left-empty.
A nil check is performed before passing throughput to CAPA and MAPI.
A set of unit tests to introduce to double-check the validations for throughput.

openshift-ci-robot · 2025-11-26T18:36:46Z

@tthvo: This pull request references CORS-4212 which is a valid jira issue.

Details

In response to this:

Descriptions

GP3 volumes have the ability to configure throughput from 125 MiB/s to 2000 MiB/s. This allows the ability to set this at install time in the install-config.

This is a take-2 of #9945 after it was reverted in #10131 due to aws serial test failure.

Notes

The following new changes are introduced:

The throughput field is now a int32 pointer to match openshift/api. It does break the convention with iops, but at least it gives us an option to represent specified vs left-empty.

A nil check is performed before passing throughput to CAPA and MAPI.

A set of unit tests to introduce to double-check the validations for throughput.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2025-11-26T18:39:43Z

/cc @patrickdillon @jianlinliu @yunjiang29 @liweinan

tthvo · 2025-11-26T18:43:19Z

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

openshift-ci · 2025-11-26T18:43:23Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c7bb9e60-caf7-11f0-854d-0994ba12b72e-0

tthvo · 2025-11-26T18:43:43Z

/label platform/aws

tthvo · 2025-11-26T18:55:55Z

/test e2e-aws-ovn-public-subnets e2e-aws-ovn-public-ipv4-pool e2e-aws-ovn-custom-iam-profile e2e-aws-overlay-mtu-ovn-1200

tthvo · 2025-11-26T19:52:48Z

/cc @JoelSpeed

tthvo · 2025-11-26T22:41:16Z

/retest

Test failures seem fine (unrelated) 👀

tthvo · 2025-11-26T22:42:11Z

* periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c7bb9e60-caf7-11f0-854d-0994ba12b72e-0

Payload passed this time 👍

liweinan · 2025-11-27T14:30:20Z

Used the build: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1993960674010599424

Verified by the script locally: https://github.com/openshift/release/pull/71426/files#diff-5e156492e6ec7b6cc1782f27eb74071576df36e33d3caf3f92f73084af22a03f

cd /Users/weli/works/oc-swarm/release && SHARED_DIR=/tmp/work4-shared CLUSTER_PROFILE_DIR=/tmp/work4-shared bash ci-operator/step-registry/cucushift/installer/check/aws/rootvolume/cucushift-installer-check-aws-rootvolume-commands.sh
Cluster ID: weli-test-8fm49
Region: us-east-1
Expected compute throughput: 1000 MiB/s
Expected control plane throughput: 1200 MiB/s
Expected worker rootVolume size: 120 GiB
Expected control-plane rootVolume size: 150 GiB
Checking worker nodes
PASS: ip-10-0-39-111.ec2.internal volume vol-034246304384809e8 type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
PASS: ip-10-0-4-150.ec2.internal volume vol-05f55a2f17af0cf1c type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
PASS: ip-10-0-64-225.ec2.internal volume vol-08f7acd7aa708a280 type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
Checking control plane nodes
PASS: ip-10-0-30-251.ec2.internal volume vol-097a2aef4a22e5f3f type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
PASS: ip-10-0-51-181.ec2.internal volume vol-084b2e4af55d5e006 type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
PASS: ip-10-0-64-82.ec2.internal volume vol-0aab6f02caafe824c type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
==========================================
Test Summary
All root volume throughput checks passed.

/verified by liweinan

openshift-ci-robot · 2025-11-27T14:30:32Z

@liweinan: This PR has been marked as verified by liweinan.

Details

In response to this:

Used the build: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1993960674010599424

Verified by the script locally: https://github.com/openshift/release/pull/71426/files#diff-5e156492e6ec7b6cc1782f27eb74071576df36e33d3caf3f92f73084af22a03f

cd /Users/weli/works/oc-swarm/release && SHARED_DIR=/tmp/work4-shared CLUSTER_PROFILE_DIR=/tmp/work4-shared bash ci-operator/step-registry/cucushift/installer/check/aws/rootvolume/cucushift-installer-check-aws-rootvolume-commands.sh
Cluster ID: weli-test-8fm49
Region: us-east-1
Expected compute throughput: 1000 MiB/s
Expected control plane throughput: 1200 MiB/s
Expected worker rootVolume size: 120 GiB
Expected control-plane rootVolume size: 150 GiB
Checking worker nodes
PASS: ip-10-0-39-111.ec2.internal volume vol-034246304384809e8 type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
PASS: ip-10-0-4-150.ec2.internal volume vol-05f55a2f17af0cf1c type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
PASS: ip-10-0-64-225.ec2.internal volume vol-08f7acd7aa708a280 type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
Checking control plane nodes
PASS: ip-10-0-30-251.ec2.internal volume vol-097a2aef4a22e5f3f type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
PASS: ip-10-0-51-181.ec2.internal volume vol-084b2e4af55d5e006 type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
PASS: ip-10-0-64-82.ec2.internal volume vol-0aab6f02caafe824c type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
==========================================
Test Summary
All root volume throughput checks passed.

/verified by liweinan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

patrickdillon · 2025-12-01T20:22:59Z

/approve

this lgtm, but some nits for discussion from joel & me

openshift-ci · 2025-12-01T20:23:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

GP3 volumes have the ability to configure throughput from 125 MiB/s to 2000 MiB/s. This allows the ability to set this at install time in the install-config. https://issues.redhat.com/browse/CORS-4212

tthvo · 2025-12-02T05:01:47Z

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

openshift-ci · 2025-12-02T05:01:51Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/01e0ea30-cf3c-11f0-93dc-8540f2bc3d99-0

tthvo · 2025-12-02T16:56:55Z

/retest

tthvo · 2025-12-02T20:36:17Z

Alr, payload testing is good and e2e is happy. I think the latest commit is fine :D

patrickdillon · 2025-12-02T21:14:01Z

Thanks for including the link to the existing code setting the the default disk type:

installer/pkg/asset/machines/worker.go

Lines 102 to 117 in fd5a518

    
           func defaultAWSMachinePoolPlatform(poolName string) awstypes.MachinePool { 
        
           	defaultEBSType := awstypes.VolumeTypeGp3 
        
           	// gp3 is not offered in all local-zones locations used by Edge Pools. 
        
           	// Once it is available, it can be used as default for all machine pools. 
        
           	// https://aws.amazon.com/about-aws/global-infrastructure/localzones/features 
        
           	if poolName == types.MachinePoolEdgeRoleName { 
        
           		defaultEBSType = awstypes.VolumeTypeGp2 
        
           	} 
        
           	return awstypes.MachinePool{ 
        
           		EC2RootVolume: awstypes.EC2RootVolume{ 
        
           			Type: defaultEBSType, 
        
           			Size: decimalRootVolumeSize, 
        
           		}, 
        
           	} 
        
           }

Now that we have moved setting the default earlier in the asset graph, should we remove it from worker.go?

/lgtm

tthvo · 2025-12-02T21:22:44Z

Now that we have moved setting the default earlier in the asset graph, should we remove it from worker.go?

Right 👍, I will open a follow-up ASAP after this one is merged to isolate the changes for easier review :D

liweinan · 2025-12-03T12:20:23Z

Using the build:

anan@think:~/works/openshift-versions$ ./openshift-install version
./openshift-install 4.21.0-0-2025-12-02-105806-test-ci-ln-jqngl8b-latest
built from commit afa4ba42082d64beae9b0b202ca0ff05b509a5a5
release image registry.build07.ci.openshift.org/ci-ln-jqngl8b/release@sha256:096b306535d0dda90848f3083acdb1edb3cea8cd1199a9b0c8b1dd66b7ed5a32
release architecture amd64
anan@think:~/works/openshift-versions$ ./openshift-install explain installconfig.platform.aws.defaultMachinePlatform.rootVolume.throughput
KIND:     InstallConfig
VERSION:  v1

RESOURCE: <integer>
  Format: int32
  Throughput to provision in MiB/s supported for the volume type. Not applicable to all types.

This parameter is valid only for gp3 volumes.
Valid Range: Minimum value of 125. Maximum value of 2000.

When omitted, this means no opinion, and the platform is left to
choose a reasonable default, which is subject to change over time.
The current default is 125.

Here is the boundary test result:

anan@think:~/works/openshift-versions/works$ ../openshift-install create-manifests
FATA[0000] Error executing openshift-install: unknown command "create-manifests" for "openshift-install" 
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: [platform.aws.defaultMachinePlatform.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s, controlPlane.platform.aws.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s, compute[0].platform.aws.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s] 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: [platform.aws.defaultMachinePlatform.throughput: Invalid value: 500: throughput not supported for type gp2, controlPlane.platform.aws.throughput: Invalid value: 500: throughput not supported for type gp2, compute[0].platform.aws.throughput: Invalid value: 500: throughput not supported for type gp2] 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: controlPlane.platform.aws.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: controlPlane.platform.aws.throughput: Invalid value: 500: throughput not supported for type gp2 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: [compute[0].name: Unsupported value: "": supported values: "worker", "edge", compute[0].platform.aws.throughput: Invalid value: 500: throughput not supported for type gp2] 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: [compute[0].name: Unsupported value: "": supported values: "worker", "edge", compute[0].platform.aws.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s] 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: failed to unmarshal install-config.yaml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go struct field EC2RootVolume.compute.platform.aws.rootVolume.throughput of type int32 
anan@think:~/works/openshift-versions/works$ 
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: compute[0].name: Unsupported value: "": supported values: "worker", "edge" 
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: compute[0].platform.aws: Required value: zone is required when using edge machine pools

The test result is expected.

/verified by liweinan

openshift-ci-robot · 2025-12-03T12:20:35Z

@liweinan: This PR has been marked as verified by liweinan.

Details

In response to this:

Using the build:

anan@think:~/works/openshift-versions$ ./openshift-install version
./openshift-install 4.21.0-0-2025-12-02-105806-test-ci-ln-jqngl8b-latest
built from commit afa4ba42082d64beae9b0b202ca0ff05b509a5a5
release image registry.build07.ci.openshift.org/ci-ln-jqngl8b/release@sha256:096b306535d0dda90848f3083acdb1edb3cea8cd1199a9b0c8b1dd66b7ed5a32
release architecture amd64
anan@think:~/works/openshift-versions$ ./openshift-install explain installconfig.platform.aws.defaultMachinePlatform.rootVolume.throughput
KIND:     InstallConfig
VERSION:  v1

RESOURCE: <integer>
 Format: int32
 Throughput to provision in MiB/s supported for the volume type. Not applicable to all types.

This parameter is valid only for gp3 volumes.
Valid Range: Minimum value of 125. Maximum value of 2000.

When omitted, this means no opinion, and the platform is left to
choose a reasonable default, which is subject to change over time.
The current default is 125.

Here is the boundary test result:

anan@think:~/works/openshift-versions/works$ ../openshift-install create-manifests
FATA[0000] Error executing openshift-install: unknown command "create-manifests" for "openshift-install" 
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: [platform.aws.defaultMachinePlatform.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s, controlPlane.platform.aws.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s, compute[0].platform.aws.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s] 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: [platform.aws.defaultMachinePlatform.throughput: Invalid value: 500: throughput not supported for type gp2, controlPlane.platform.aws.throughput: Invalid value: 500: throughput not supported for type gp2, compute[0].platform.aws.throughput: Invalid value: 500: throughput not supported for type gp2] 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: controlPlane.platform.aws.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: controlPlane.platform.aws.throughput: Invalid value: 500: throughput not supported for type gp2 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: [compute[0].name: Unsupported value: "": supported values: "worker", "edge", compute[0].platform.aws.throughput: Invalid value: 500: throughput not supported for type gp2] 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: [compute[0].name: Unsupported value: "": supported values: "worker", "edge", compute[0].platform.aws.throughput: Invalid value: 0: throughput must be between 125 MiB/s and 2000 MiB/s] 
anan@think:~/works/openshift-versions/works$ cp install-config.yaml.bkup install-config.yaml
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: failed to unmarshal install-config.yaml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go struct field EC2RootVolume.compute.platform.aws.rootVolume.throughput of type int32 
anan@think:~/works/openshift-versions/works$ 
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: compute[0].name: Unsupported value: "": supported values: "worker", "edge" 
anan@think:~/works/openshift-versions/works$ ../openshift-install create manifests
ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: compute[0].platform.aws: Required value: zone is required when using edge machine pools

The test result is expected.

/verified by liweinan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

patrickdillon · 2025-12-03T21:53:54Z

/label acknowledge-critical-fixes-only

openshift-ci · 2025-12-04T01:59:10Z

@tthvo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-heterogeneous	`2a98b2b`	link	false	`/test e2e-aws-ovn-heterogeneous`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tthvo · 2025-12-04T02:08:45Z

/test e2e-aws-ovn

jianlinliu · 2025-12-04T02:51:07Z

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview

openshift-ci · 2025-12-04T02:51:11Z

@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/15c47130-d0bc-11f0-9b9b-2c57df1b8c81-0

jianlinliu · 2025-12-04T02:58:14Z

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3

openshift-ci · 2025-12-04T02:58:18Z

@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/13f0f440-d0bd-11f0-8f62-9c6e66133ce8-0

tthvo · 2025-12-04T04:41:39Z

/hold

For payload testing 👀

jianlinliu · 2025-12-04T06:40:29Z

/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3

openshift-ci · 2025-12-04T06:40:33Z

@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/20eb27f0-d0dc-11f0-80f4-5aa249dd7935-0

jianlinliu · 2025-12-04T13:34:20Z

all the payload ci jobs got passed, the PR looks good.

tthvo · 2025-12-04T16:59:41Z

all the payload ci jobs got passed, the PR looks good.

Oh thanks! Let's get this merged 🚀

/hold cancel

tthvo · 2025-12-04T17:07:36Z

/skip

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2025

openshift-ci Bot requested review from jhixson74 and mtulio November 26, 2025 18:38

openshift-ci Bot requested review from jianlinliu, liweinan, patrickdillon and yunjiang29 November 26, 2025 18:39

tthvo mentioned this pull request Nov 26, 2025

CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes #9945

Merged

openshift-ci Bot added the platform/aws label Nov 26, 2025

openshift-ci Bot requested a review from JoelSpeed November 26, 2025 19:52

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 27, 2025

JoelSpeed reviewed Dec 1, 2025

View reviewed changes

Comment thread pkg/asset/machines/aws/machines.go Outdated

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025

jhixson74 added 3 commits December 1, 2025 17:12

Bump openshift/api for AWS GP3 changes

c17a0ff

go mod vendor for AWS GP3 changes

d05387a

AWS: Add the ability to configure throughput on GP3 volumes

d93d030

GP3 volumes have the ability to configure throughput from 125 MiB/s to 2000 MiB/s. This allows the ability to set this at install time in the install-config. https://issues.redhat.com/browse/CORS-4212

tthvo force-pushed the CORS-4212 branch from d636ff2 to f430036 Compare December 2, 2025 01:19

patrickdillon reviewed Dec 2, 2025

View reviewed changes

Comment thread pkg/types/defaults/machinepools.go

openshift-ci Bot assigned patrickdillon Dec 2, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 3, 2025

openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 3, 2025

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025

openshift-merge-bot Bot merged commit b35dbe6 into openshift:main Dec 4, 2025
30 checks passed

tthvo deleted the CORS-4212 branch December 4, 2025 21:09

Conversation

tthvo commented Nov 26, 2025

Descriptions

Notes

Uh oh!

openshift-ci-robot commented Nov 26, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Descriptions

Notes

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

openshift-ci Bot commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

liweinan commented Nov 27, 2025

Uh oh!

openshift-ci-robot commented Nov 27, 2025

Uh oh!

Uh oh!

patrickdillon commented Dec 1, 2025

Uh oh!

openshift-ci Bot commented Dec 1, 2025

Uh oh!

tthvo commented Dec 2, 2025

Uh oh!

openshift-ci Bot commented Dec 2, 2025

Uh oh!

tthvo commented Dec 2, 2025

Uh oh!

tthvo commented Dec 2, 2025

Uh oh!

Uh oh!

patrickdillon commented Dec 2, 2025

Uh oh!

tthvo commented Dec 2, 2025

Uh oh!

liweinan commented Dec 3, 2025

Uh oh!

openshift-ci-robot commented Dec 3, 2025

Uh oh!

patrickdillon commented Dec 3, 2025

Uh oh!

openshift-ci Bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tthvo commented Dec 4, 2025

Uh oh!

jianlinliu commented Dec 4, 2025

Uh oh!

openshift-ci Bot commented Dec 4, 2025

Uh oh!

jianlinliu commented Dec 4, 2025

Uh oh!

openshift-ci Bot commented Dec 4, 2025

Uh oh!

tthvo commented Dec 4, 2025

Uh oh!

jianlinliu commented Dec 4, 2025

Uh oh!

openshift-ci Bot commented Dec 4, 2025

Uh oh!

jianlinliu commented Dec 4, 2025

Uh oh!

tthvo commented Dec 4, 2025

Uh oh!

tthvo commented Dec 4, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 26, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci Bot commented Dec 4, 2025 •

edited

Loading