AGENT-1326, MCO-1961: copy image-references for machine-config-controller bootstrap#10134
Conversation
|
@andfasano: This pull request references AGENT-1326 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. This pull request references MCO-1961 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note (and just for the IRI controller): the current new version of openshift/machine-config-operator#5452 is not currently requiring this change, but in any case it could be potentially useful for the future. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ? |
|
@andfasano: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-agent-compact-ipv4 |
|
Pre-merge verification steps: Environment Setup Manual installation $ oc adm -a pull-secret.txt release extract --tools registry.build07.ci.openshift.org/ci-ln-lwgh7m2/release:latest
$ tar -xvf openshift-install-linux-4.21.0-0-2025-12-02-042848-test-ci-ln-lwgh7m2-latest.tar.gz
$ ./openshift-install create cluster
<provide the creds>
$ ssh core@3.236.254.171
[root@ip-10-0-177-182 core]# ls /etc/mcc/bootstrap/ | grep -i image-ref
image-references
[root@ip-10-0-177-182 core]# head -15 /etc/mcc/bootstrap/image-references
{
"kind": "ImageStream",
"apiVersion": "image.openshift.io/v1",
"metadata": {
"name": "4.21.0-0-2025-12-02-042848-test-ci-ln-lwgh7m2-latest",
"creationTimestamp": "2025-12-02T04:28:54Z",
"annotations": {
"release.openshift.io/from-image-stream": "ci-ln-lwgh7m2/stable"
}
},
"spec": {
"lookupPolicy": {
"local": false
},
[root@ip-10-0-177-182 core]# crictl ps | grep machine-config
3ff9fbe2a18dc 65fdc9116500daafa33e6c5bb5697282bf88b8d3f0edf0357b81b1cf3f847ff9 15 minutes ago Running machine-config-server 0 56782ed1c0b5e bootstrap-machine-config-operator-ip-10-0-177-182 default
$ oc get clusterversions.config.openshift.io
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.21.0-0-2025-12-02-042848-test-ci-ln-lwgh7m2-latest True False 5m41s Cluster version is 4.21.0-0-2025-12-02-042848-test-ci-ln-lwgh7m2-latest
$ oc get co machine-config
NAME VERSION AVAILABLE PROGRESSING DEGRADED SINCE MESSAGE
machine-config 4.21.0-0-2025-12-02-042848-test-ci-ln-lwgh7m2-latest True False False 29m /verified by @ptalgulk01 |
|
@andfasano: This pull request references AGENT-1326 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. This pull request references MCO-1961 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ptalgulk01: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@andfasano: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
98521ad
into
openshift:main
There are currently two different machine-config-controller controllers under work that are requiring to extract the image references data during the bootstrap (OSImageStream and InternalReleaseImage).
This patch copies the image-references file in the expected destination folder
cc @pablintino