Update machines namespace#1215
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Feb 11, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/S
Contributor
|
/test e2e-aws |
1 similar comment
Member
Author
|
/test e2e-aws |
Contributor
|
Ques: why does this not change namespace for openstack. /approve |
openshift-ci-robot
added
the
approved
Member
Author
|
@abhinavdahiya I leave it to them to put the corresponding PR for Openstack so they can do it in sync with their actuator changes |
Member
Author
|
friendly ping @wking |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford, enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fedosin
added a commit
to Fedosin/installer
that referenced
this pull request
Feb 13, 2019
PR openshift#1215 changed namespaces for machines and machinesets for all providers, except OpenStack. This commit fixes the remaining parts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are pivoting machines API towards machine.openshift.io we want to be consistent with namespace name
For reference:
openshift/machine-api-operator#202
blocks:
openshift/cluster-autoscaler-operator#43
openshift/kubernetes-autoscaler#33
openshift/machine-api-operator#203