Skip to content

openstack: Update machines namespace for OpenStack#1245

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Fedosin:update_machines_namespace
Feb 16, 2019
Merged

openstack: Update machines namespace for OpenStack#1245
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Fedosin:update_machines_namespace

Conversation

@Fedosin
Copy link
Copy Markdown
Contributor

@Fedosin Fedosin commented Feb 13, 2019

PR #1215 changed namespaces for machines and machinesets for all providers, except OpenStack.
This commit fixes the remaining parts.

@Fedosin
Update machines namespace for OpenStack
425ac3d 
PR openshift#1215 changed
namespaces for machines and machinesets for all providers, except
OpenStack.
This commit fixes the remaining parts.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 13, 2019

Hi @Fedosin. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2019
@tomassedovic
Copy link
Copy Markdown
Contributor

tomassedovic commented Feb 13, 2019

/assign @tomassedovic

@tomassedovic
Copy link
Copy Markdown
Contributor

tomassedovic commented Feb 13, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2019
@Fedosin Fedosin changed the title Update machines namespace for OpenStack openstack: Update machines namespace for OpenStack Feb 13, 2019
@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Feb 13, 2019

duplicate of #1246

@flaper87
Copy link
Copy Markdown
Contributor

flaper87 commented Feb 13, 2019

/test e2e-aws
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, flaper87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@flaper87
Copy link
Copy Markdown
Contributor

flaper87 commented Feb 14, 2019

/test e2e-aws

1 similar comment
@flaper87
Copy link
Copy Markdown
Contributor

flaper87 commented Feb 14, 2019

/test e2e-aws

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Feb 14, 2019 •
edited
Loading

@flaper87 @Fedosin if you are ok with moving the cluster object as well https://github.com/openshift/installer/blob/master/pkg/asset/manifests/cluster_k8s_io.go#L56
then we can totally drop the openshift-cluster-api namespace

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@flaper87
Copy link
Copy Markdown
Contributor

flaper87 commented Feb 14, 2019

@enxebre I'll do it, thanks!

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@tomassedovic
Copy link
Copy Markdown
Contributor

tomassedovic commented Feb 15, 2019

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5af1819 into openshift:master Feb 16, 2019
@Fedosin Fedosin deleted the update_machines_namespace branch November 1, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb Awaiting requested review from russellb

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@flaper87 flaper87

@tomassedovic tomassedovic

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Fedosin @openshift-ci-robot @tomassedovic @abhinavdahiya @flaper87 @openshift-bot @enxebre @openshift-merge-robot