Skip to content

openstack: complete move of OpenStack under the downstream machine api#1246

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
flaper87:prepare-for-downstream-machine-api
Feb 15, 2019
Merged

openstack: complete move of OpenStack under the downstream machine api#1246
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
flaper87:prepare-for-downstream-machine-api

Conversation

@flaper87
Copy link
Copy Markdown
Contributor

@flaper87 flaper87 commented Feb 13, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@flaper87
Copy link
Copy Markdown
Contributor Author

flaper87 commented Feb 13, 2019

/hold
cc @tomassedovic @trown

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 13, 2019
@flaper87
Copy link
Copy Markdown
Contributor Author

flaper87 commented Feb 13, 2019

/assign @enxebre

@tomassedovic
Copy link
Copy Markdown
Contributor

tomassedovic commented Feb 13, 2019

@flaper87 just checking: this depends on openshift/cluster-api-provider-openstack#16 right?

enxebre
enxebre reviewed Feb 13, 2019
View reviewed changes
Comment thread pkg/asset/machines/openstack/machines.go Outdated
@flaper87 flaper87 force-pushed the prepare-for-downstream-machine-api branch from 78cff76 to 164196d Compare February 13, 2019 17:26
@abhinavdahiya abhinavdahiya mentioned this pull request Feb 13, 2019
Merged
@flaper87
Copy link
Copy Markdown
Contributor Author

flaper87 commented Feb 14, 2019

/test e2e-aws

1 similar comment
@flaper87
Copy link
Copy Markdown
Contributor Author

flaper87 commented Feb 14, 2019

/test e2e-aws

@flaper87 flaper87 force-pushed the prepare-for-downstream-machine-api branch from 164196d to 0fa755b Compare February 14, 2019 12:09
@tomassedovic
Copy link
Copy Markdown
Contributor

tomassedovic commented Feb 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@tomassedovic
Copy link
Copy Markdown
Contributor

tomassedovic commented Feb 14, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2019
@flaper87
Copy link
Copy Markdown
Contributor Author

flaper87 commented Feb 14, 2019

/test e2e-aws

@flaper87 flaper87 force-pushed the prepare-for-downstream-machine-api branch from 0fa755b to 5030241 Compare February 14, 2019 14:00
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@tomassedovic
Copy link
Copy Markdown
Contributor

tomassedovic commented Feb 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [flaper87,tomassedovic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

enxebre
enxebre reviewed Feb 14, 2019
View reviewed changes
Comment thread pkg/asset/manifests/cluster_k8s_io.go
},
ObjectMeta: metav1.ObjectMeta{
Name: installconfig.Config.ObjectMeta.Name,
Namespace: "openshift-cluster-api",
Copy link
Copy Markdown
Member

@enxebre enxebre Feb 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using this object on the actuator, you probably need to update the APIVersion version here l51 APIVersion: "cluster.k8s.io/v1alpha1" to be consistent with what the actuator is taking

Copy link
Copy Markdown
Contributor Author

@flaper87 flaper87 Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine. I can prolly change this in a follow-up patch

@flaper87
Copy link
Copy Markdown
Contributor Author

flaper87 commented Feb 14, 2019

/test e2e-aws

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f8224ba into openshift:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@hardys hardys Awaiting requested review from hardys

1 more reviewer

@enxebre enxebre enxebre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tomassedovic tomassedovic

@enxebre enxebre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@flaper87 @tomassedovic @openshift-ci-robot @openshift-bot @enxebre @openshift-merge-robot