Skip to content

openstack: add image for openstack ci#1466

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
trown:openstack-ci
Apr 1, 2019
Merged

openstack: add image for openstack ci#1466
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
trown:openstack-ci

Conversation

@trown
Copy link

@trown trown commented Mar 26, 2019

Adds a CI image for use by the openstack e2e job which has the openstack cli clients.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2019
@trown
Copy link
Author

trown commented Mar 27, 2019

/test e2e-aws

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdahiya In my local tests, the epel-release and rdo-release rpms were not available in the base image. I had to install them from https links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have log from failure...
did it look like #1456 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just didnt find the package. So it fails silently, but then the openstackclient is not installed.

@trown
Copy link
Author

trown commented Mar 27, 2019

/test e2e-aws

@trown
Copy link
Author

trown commented Mar 28, 2019

@abhinavdahiya could we merge this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this go in images/openstack/Dockerfile.ci or similar with an OWNERS file? The UPI file is here because we expect it to be cross-platform.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that makes sense. thanks for the review

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2019
@wking
Copy link
Member

wking commented Apr 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, trown, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@trown
Copy link
Author

trown commented Apr 1, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 8d15d60 into openshift:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants