openstack: Use CI DNS server to resolve API URL#3236
openstack: Use CI DNS server to resolve API URL#3236openshift-merge-robot merged 2 commits intoopenshift:masterfrom trown:openstack-ci
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
size/M
trown
changed the title
|
openshift/installer#1466 merged. If the openstack rehearse job gets to the point where a FIP is pulled this should be good to go. |
|
/test pj-rehearse |
|
This (grep "failed to initialize the cluster") failed in the same way the install currently fails for me manually. I think we should go ahead and merge this, as it gives us concurrent working (in terms of accuracy) CI jobs. We can then add fixes in smaller follow-up PRs. |
tomassedovic
left a comment
tomassedovic
left a comment
There was a problem hiding this comment.
Looks good to me, but I'd like to check the floating IP creation and assignment bit actually does what it's supposed to.
There was a problem hiding this comment.
This can be written as: openstack floating ip list -f value -c 'Floating IP Address', which I'd say is cleaner and more robust (the default view is not really supposed to be used by scripts and can change).
More importantly though, won't this fail if there's another job running already? There will be a floating IP in that case, but it will be in use so we shouldn't be taking it.
There was a problem hiding this comment.
Indeed, see my change at https://github.com/shiftstack-dev-tools/shiftstack-ci/pull/6/files
There was a problem hiding this comment.
Yes it is missing the --status DOWN check. Nice catch. I will also fix the awks.
We need to use a DNS server we control in order to resolve the API URL. This server is now setup in the CI tenant, and allows posting A records in the shiftstack.ci domain.
|
Thanks! That looks good to me. Let's see what the Out of curiosity, how does the |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomassedovic, trown The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@trown: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
We need to use a DNS server we control in order to resolve the API
URL. This server is now setup in the CI tenant, and allows posting
A records in the shiftstack.ci domain.
This requires a special CI image with the openstackclient installed:
openshift/installer#1466