*: remove the deprecated kube-system coreos-pull-secret#1567
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Apr 16, 2019
Merged
*: remove the deprecated kube-system coreos-pull-secret#1567openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
PR openshift#1554 marked kube-system coreos-pull-secret deprecated in favor of openshift-config pull-secret consumer PRs like openshift/origin#22508 openshift/machine-config-operator#609 should allow removal now.
openshift-ci-robot
added
size/M
Member
Discussion in rhbz#1680201. /retest |
Member
|
/lgtm Although this may not pass until openshift/origin#22508 actually lands (it's currently in the merge queue). |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
/hold Until openshift/origin#22508 lands. |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
|
/retest |
Contributor
Author
|
openshift/origin#22508 merged so ^^ should close the loop on all the consumers. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
Author
|
e2e-aws failure: rate limited: level=error msg="Error: Error applying plan:"
level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.vpc.aws_route.igw_route: 1 error occurred:"
level=error msg="\t* aws_route.igw_route: Error creating route: timeout while waiting for state to become 'success' (timeout: 2m0s)"/retest |
Contributor
Author
Failing tests:
[Feature:Platform] Managed cluster should have no crashlooping pods in core namespaces over two minutes [Suite:openshift/conformance/parallel]looks like deleting the pull-secret didn't create any problems. :yay: /retest |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1554 marked kube-system coreos-pull-secret deprecated in favor of openshift-config pull-secret
consumer PRs like openshift/origin#22508 openshift/machine-config-operator#609 should allow removal now.