Bug 1697644: test/extended: update test to use openshift-config pull-secret#22508
Conversation
|
/retest |
|
/refresh |
|
/lgtm |
PR openshift#1554 marked kube-system coreos-pull-secret deprecated in favor of openshift-config pull-secret consumer PRs like openshift/origin#22508 openshift/machine-config-operator#609 should allow removal now.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Looks like verify failed on the Go 1.11 bump (openshift/release#3394). Maybe that's what's going on with the unit tests too? $ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/22508/pull-ci-openshift-origin-master-unit/4939/artifacts/unit/unit.log.gz | gunzip | grep GetNameFromCallsite/ignore-package
{"Time":"2019-04-09T23:43:06.158172797Z","Action":"run","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package"}
{"Time":"2019-04-09T23:43:06.158193705Z","Action":"output","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package","Output":"=== RUN TestGetNameFromCallsite/ignore-package\n"}
{"Time":"2019-04-09T23:43:06.159995273Z","Action":"output","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package","Output":" --- FAIL: TestGetNameFromCallsite/ignore-package (0.00s)\n"}
{"Time":"2019-04-09T23:43:06.160000271Z","Action":"output","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package","Output":" from_stack_test.go:52: expected \"testing/testing.go:777\", got \"testing/testing.go:827\"\n"}
{"Time":"2019-04-09T23:43:06.160009673Z","Action":"fail","Package":"github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/naming","Test":"TestGetNameFromCallsite/ignore-package","Elapsed":0} |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Should be fixed by now. @wking ping me if there are some problems still. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Hunting... |
|
Build history has this as a one-off failure, so kicking again in case it was just a fluke. /retest |
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
unit: /test unit |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
requires: openshift/installer#1554
/cc @smarterclayton