[FCOS] support libvirt install by vrutkovs · Pull Request #2678 · openshift/installer

vrutkovs · 2019-11-15T13:48:14Z

Update links to FCOS qcow
Extract xz-compressed images in libvirt

Requires openshift/release#5933 to add libvirt test.

[fcos] Add vrutkovs and LorbusChris to OWNERS

…pivot before proceeding

This PR updated the current building system and ci images from golang 1.10 to 1.12.

Rather than doing a `systemctl restart crio` after `kubelet.service` has started, separate out the bit that changes the pause image into a small separate service.

The kubelet template in the MCO should be considered canonical. We want the crio.service dependencies in particular.

If one of these commands happens to exit with an error, we don't want to blindly stumble on. Furthermore, `-u` helps guard against typos. http://redsymbol.net/articles/unofficial-bash-strict-mode/

[fcos] Support Ignition3 and FCOS

openshift-ci-robot · 2019-11-15T13:48:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrutkovs · 2019-11-15T15:54:55Z

/hold

until openshift/release#5933 lands so that it could be properly tested

stbenjam · 2019-11-15T16:54:20Z

-            "size": 700315704,
-            "uncompressed-sha256": "b4cd810376dca356f987e2e7f8609f84d63720d5ad19d3101f84e82d1918c85e",
-            "uncompressed-size": 1889337344
+            "path": "fedora-coreos-30.20191014.0-qemu.x86_64.qcow2.xz",


This is going to break baremetal, we rely on the QEMU image for the bootstrap node - it seems odd to have mixed RHCOS/FCOS content here, shouldn't it be one or the other for everything?

Also the next time someone runs the hack script to update the RHCOS build this will all get overwritten.

Baremetal IPI is currently not supported on OKD-on-FCOS - Ironic bits need to be replaced with UBI8 + RDO, hack script updated etc. I'll make another PR once it gets there

Right I get that it won't work with OKD-on-FCOS, but this is breaking baremetal IPI entirely. Is all of openshift/install master moving to FCOS and too bad for any platforms that don't work with it yet?

My concern here is baremetal IPI has been broken for weeks, and we're very close to recovering from it and having working CI again. Now, with this change, our Metal3 CI can't be run against anything in master, so we really have no idea if some future commits break us until it ends up in a release branch :-(

Sorry for the noise, it was just pointed out to me this isn't going to the master branch. I'm keen to get baremetal IPI working with FCOS but doesn't need to hold up this patch. Disregard me 🤦‍♂️

it seems odd to have mixed RHCOS/FCOS content here, shouldn't it be one or the other for everything?

@vrutkovs I think this very important question from @stbenjam wasn't answered. If the answer is that we're just moving everything to FCOS, I think we should rename the file and (more importantly) commit log should reflect the reason for the change.

This PR is only for the fcos branch, it won't affect main development on master.

zeenix · 2019-11-18T10:07:38Z

-			SHA256 string `json:"sha256"`
+			Path               string `json:"path"`
+			SHA256             string `json:"sha256"`
+			UncompressedSHA256 string `json:"uncompressed-sha256"`


Some info in the commit log details on why this change is needed, would be good.

zeenix · 2019-11-19T10:43:21Z

-            "size": 700315704,
-            "uncompressed-sha256": "b4cd810376dca356f987e2e7f8609f84d63720d5ad19d3101f84e82d1918c85e",
-            "uncompressed-size": 1889337344
+            "path": "fedora-coreos-30.20191014.0-qemu.x86_64.qcow2.xz",


it seems odd to have mixed RHCOS/FCOS content here, shouldn't it be one or the other for everything?

@vrutkovs I think this very important question from @stbenjam wasn't answered. If the answer is that we're just moving everything to FCOS, I think we should rename the file and (more importantly) commit log should reflect the reason for the change.

zeenix · 2019-11-19T10:45:37Z

/approve cancel

vrutkovs · 2019-11-21T16:01:33Z

/retest

vrutkovs · 2019-12-02T12:37:01Z

@vrutkovs I think this very important question from @stbenjam wasn't answered. If the answer is that we're just moving everything to FCOS, I think we should rename the file and (more importantly) commit log should reflect the reason for the change.

Both changes would be addressed in followup PRs. Baremetal supports depends on openstack images rebuilt from RDO (instead of OSP). rhcos.json needs a consensus from architects on the chosen name. At this point we keep the same name to avoid extra changes during regular rebases from master

openshift-ci-robot · 2020-01-31T01:33:42Z

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere	`b9870bb`	link	`/test e2e-vsphere`
ci/prow/e2e-aws	`b9870bb`	link	`/test e2e-aws`
ci/prow/tf-lint	`b9870bb`	link	`/test tf-lint`
ci/prow/shellcheck	`b9870bb`	link	`/test shellcheck`
ci/prow/yaml-lint	`b9870bb`	link	`/test yaml-lint`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2020-01-31T01:33:44Z

@vrutkovs: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2020-02-04T17:26:47Z

No longer required - all fixes have been merged in the branch

Vadim Rutkovsky and others added 30 commits October 24, 2019 20:49

hack/build: allow building outside of GOPATH

09dbe02

Drop tests

04f0836

Use go modules and remove vendored files

2236050

Use ignition v3.0 and update MCO

f5662b3

Remove azure

dee51dd

Merge go.mod's into one

9ce59d1

Bump MCO

26b6a57

Add vrutkovs and LorbusChris to OWNERS

37561d5

Merge pull request openshift#2601 from vrutkovs/fcos-owners-vrutkovs

36ca119

[fcos] Add vrutkovs and LorbusChris to OWNERS

rhcos.json: use Fedora CoreOS AMIs instead of RHCOS

a8c30d2

hack/build.sh: remove unused LAUNCH_PATH

6d12439

bootstrap: pull MCD image, copy machine-config-daemon binary and run …

0d9c761

…pivot before proceeding

bootstrap: overwrite all files by default

065479d

Install cgroups config for bootstrap

44c3a5b

openshift/machine-config-operator#581

bootstrap.sh: set nosmt and drop cgroupsv2 on all machines

9cc0081

Update images/mock to go 1.12 and include generated gcp mock

a706df7

go get -u golang.org/x/lint/golint

dcfec39

Bump golang version to 1.12

6cbf970

This PR updated the current building system and ci images from golang 1.10 to 1.12.

vendor update

8d1ec7d

hack/build.sh: get vfsgen before "go generate"

aed6109

hack/verify-vendor: use "go mod vendor" instead of dep

be577f9

hack/yaml-lint: link pkg/ only

accd9f3

Fix unittests

f8ebf8b

bootkube.sh: fix machine-config-daemon extraction

6fd3474

Add crio-configure.service Before=bootkube.service

02ea3f8

Rather than doing a `systemctl restart crio` after `kubelet.service` has started, separate out the bit that changes the pause image into a small separate service.

kubelet.service: Sync up with MCO

1c7e76d

The kubelet template in the MCO should be considered canonical. We want the crio.service dependencies in particular.

Use "bash strict mode" for bootkube and release-image-download

cd7711d

If one of these commands happens to exit with an error, we don't want to blindly stumble on. Furthermore, `-u` helps guard against typos. http://redsymbol.net/articles/unofficial-bash-strict-mode/

Run crio-configure after bootstrap has pivot

e5a58b3

Merge pull request openshift#2548 from vrutkovs/okd

23f4029

[fcos] Support Ignition3 and FCOS

rhcos.json: update qcow path for libvirt

009e505

Fedosin and others added 3 commits November 14, 2019 13:37

Attach sha256 checksum to the image URL

310cd3d

Handle compressed images in libvirt installer

b9c8d7c

Move all decompression transparently to the cache

0eeb9f6

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2019

openshift-ci-robot requested review from mtnbikenc and stbenjam November 15, 2019 13:48

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019

cfergeau reviewed Nov 15, 2019

View reviewed changes

Comment thread pkg/tfvars/internal/cache/cache.go Outdated

cfergeau reviewed Nov 15, 2019

View reviewed changes

Comment thread pkg/tfvars/internal/cache/cache.go Outdated

libvirt: support xz-encoded images

b9870bb

vrutkovs force-pushed the fcos-libvirt branch from 09a35bc to b9870bb Compare November 15, 2019 15:52

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2019

stbenjam reviewed Nov 15, 2019

View reviewed changes

zeenix reviewed Nov 18, 2019

View reviewed changes

zeenix suggested changes Nov 19, 2019

View reviewed changes

hardys mentioned this pull request Nov 19, 2019

[FCOS] Update vSphere UPI #2671

Merged

4 tasks

sferich888 mentioned this pull request Dec 2, 2019

OKD support for Libvirt provider okd-project/okd#15

Closed

vrutkovs mentioned this pull request Jan 10, 2020

WIP [FCOS] rhcos.json: use FCOS image for GCP #2882

Closed

2 tasks

smarterclayton force-pushed the fcos branch from 7e1413f to 1dce0a9 Compare January 20, 2020 18:46

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020

vrutkovs closed this Feb 4, 2020

Conversation

vrutkovs commented Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 15, 2019

Uh oh!

Uh oh!

Uh oh!

vrutkovs commented Nov 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stbenjam Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stbenjam Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zeenix commented Nov 19, 2019

Uh oh!

vrutkovs commented Nov 21, 2019

Uh oh!

vrutkovs commented Dec 2, 2019

Uh oh!

openshift-ci-robot commented Jan 31, 2020

Uh oh!

openshift-ci-robot commented Jan 31, 2020

Uh oh!

vrutkovs commented Feb 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

vrutkovs commented Nov 15, 2019 •

edited

Loading

stbenjam Nov 15, 2019 •

edited

Loading

stbenjam Nov 15, 2019 •

edited

Loading