Skip to content

Bug 1808456: OpenStack: allow to overwrite default os image in the install config#3170

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Fedosin:cluster_os_image
Feb 26, 2020
Merged

Bug 1808456: OpenStack: allow to overwrite default os image in the install config#3170
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Fedosin:cluster_os_image

Conversation

@Fedosin
Copy link
Copy Markdown
Contributor

@Fedosin Fedosin commented Feb 24, 2020

This PR adds clusterOSImage parameter to the install config, that allows to override default OS image location for users.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2020
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Feb 24, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@adduarte
Copy link
Copy Markdown

adduarte commented Feb 24, 2020

/test e2e-libvirt

pierreprinetti
pierreprinetti reviewed Feb 25, 2020
View reviewed changes
Comment thread docs/user/openstack/customization.md Outdated
Copy link
Copy Markdown
Contributor

@pierreprinetti pierreprinetti Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/attach/attached/

Copy link
Copy Markdown
Contributor Author

@Fedosin Fedosin Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread docs/user/openstack/customization.md Outdated
Copy link
Copy Markdown
Contributor

@pierreprinetti pierreprinetti Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When doing a disconnected installation

strictly speaking, that requirement is always present, and not only for disconnected installs.

What about something like:

The installer downloads the RHCOS image from a predetermined location (cf [data/data/rhcos.json](/data/data/rhcos.json)). The download URL can be overridden, notably for disconnected installations.

Copy link
Copy Markdown
Contributor Author

@Fedosin Fedosin Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread docs/user/openstack/customization.md Outdated
Copy link
Copy Markdown
Contributor

@pierreprinetti pierreprinetti Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the only difference! The sha256 checksum is missing as well. I'd say instead:

If `clusterOSImage` is not an URL, then the installer will look into Glance for an image with that name.

Copy link
Copy Markdown
Contributor Author

@Fedosin Fedosin Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sdodson sdodson mentioned this pull request Feb 25, 2020
Merged
@pierreprinetti
Copy link
Copy Markdown
Contributor

pierreprinetti commented Feb 26, 2020

/lgtm

🎉

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@pierreprinetti
Copy link
Copy Markdown
Contributor

pierreprinetti commented Feb 26, 2020

/hold
/test e2e-openstack

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
@pierreprinetti
Copy link
Copy Markdown
Contributor

pierreprinetti commented Feb 26, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 26, 2020 •
edited
Loading

@Fedosin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt a64890d link /test e2e-ovirt
ci/prow/e2e-aws-scaleup-rhel7 a64890d link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt a64890d link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Copy Markdown
Contributor

pierreprinetti commented Feb 26, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit d2490ec into openshift:master Feb 26, 2020
@Fedosin Fedosin changed the title OpenStack: allow to overwrite default os image in the install config Bug 1808456: OpenStack: allow to overwrite default os image in the install config Feb 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 28, 2020

@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1808456 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1808456: OpenStack: allow to overwrite default os image in the install config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Copy Markdown
Contributor Author

Fedosin commented Feb 28, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 28, 2020

@Fedosin: #3170 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/asset/rhcos/image.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/asset/rhcos/image.go
CONFLICT (content): Merge conflict in pkg/asset/rhcos/image.go
Patch failed at 0001 OpenStack: allow to overwrite default os image in the install config
Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Copy Markdown
Contributor Author

Fedosin commented Feb 28, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 28, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 28, 2020

@Fedosin: new pull request created: #3205

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jhixson74 jhixson74 Awaiting requested review from jhixson74

1 more reviewer

@pierreprinetti pierreprinetti pierreprinetti left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pierreprinetti pierreprinetti

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Fedosin @sdodson @openshift-ci-robot @adduarte @pierreprinetti @openshift-cherrypick-robot @openshift-merge-robot