Skip to content

[release-4.4] Bug 1808460: OpenStack: allow to overwrite default os image in the install config#3205

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-3170-to-release-4.4
Mar 2, 2020
Merged

[release-4.4] Bug 1808460: OpenStack: allow to overwrite default os image in the install config#3205
openshift-merge-robot merged 2 commits intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-3170-to-release-4.4

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 28, 2020

This is an automated cherry-pick of #3170

/assign Fedosin

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 28, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 28, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1808456, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1808456 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1808456: OpenStack: allow to overwrite default os image in the install config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2020
@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Feb 28, 2020

/retitle Bug 1808460: OpenStack: allow to overwrite default os image in the install config

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1808456: OpenStack: allow to overwrite default os image in the install config Bug 1808460: OpenStack: allow to overwrite default os image in the install config Feb 28, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 28, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1808460, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1808456 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1808456 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents
Details

In response to this:

Bug 1808460: OpenStack: allow to overwrite default os image in the install config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Copy Markdown
Contributor

pierreprinetti commented Feb 28, 2020

/lgtm
/label platform/openstack

@openshift-ci-robot openshift-ci-robot added platform/openstack lgtm Indicates that a PR is ready to be merged. labels Feb 28, 2020
@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Feb 28, 2020

/retitle [release-4.4] Bug 1808460: OpenStack: allow to overwrite default os image in the install config

@openshift-ci-robot openshift-ci-robot changed the title Bug 1808460: OpenStack: allow to overwrite default os image in the install config [release-4.4] Bug 1808460: OpenStack: allow to overwrite default os image in the install config Feb 28, 2020
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Feb 28, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Feb 28, 2020

/hold

Waiting for the tests to pass

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2020
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Feb 28, 2020

/override ci/prow/e2e-aws-upgrade
Not relevant to the changes here.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 28, 2020

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-upgrade
Not relevant to the changes here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Mar 2, 2020

/retest

@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Mar 2, 2020

/test e2e-aws

@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Mar 2, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5adf7c8 into openshift:release-4.4 Mar 2, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 2, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1808460 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1808460: OpenStack: allow to overwrite default os image in the install config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 2, 2020

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 6d2097a link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@pierreprinetti pierreprinetti

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @Fedosin @pierreprinetti @sdodson @openshift-bot @openshift-merge-robot