Bug 1820575: Cherry-pick oVirt PR 3406 vNIC profiles by patrickdillon · Pull Request #3569 · openshift/installer

patrickdillon · 2020-05-07T18:28:18Z

manual cherry-pick of #3406 as it is failing due to merge conflict:
#3406 (comment)

merge conflict was simple... pkg/asset/installconfig in master has a single check for vsphere and related import which I removed. everything else picks cleanly

cc @rgolangh

Signed-off-by: Roy Golan <rgolan@redhat.com>

The vnic profile that all the VM shares can now be configurable through the platform and is part of the wizard, in case there are multiple for the selected network. ```yaml platform: ovirt: vnicProfileID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx ``` Signed-off-by: Roy Golan <rgolan@redhat.com>

openshift-ci-robot · 2020-05-07T18:28:22Z

@patrickdillon: This pull request references Bugzilla bug 1820575, which is invalid:

expected dependent Bugzilla bug 1816714 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1820575: Cherry-pick oVirt PR 3406 vNIC profiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2020-05-07T18:28:47Z

/test e2e-ovirt

openshift-ci-robot · 2020-05-07T19:14:42Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sdodson · 2020-05-07T19:42:43Z

/test e2e-ovirt

patrickdillon · 2020-05-07T20:00:54Z

Regarding CI failures we could be missing cherry picks in other repos. This is simply a guess but perhaps something like openshift/machine-config-operator#1717

patrickdillon · 2020-05-11T14:49:48Z

/bugzilla refresh

openshift-ci-robot · 2020-05-11T14:49:52Z

@patrickdillon: This pull request references Bugzilla bug 1820575, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1816714 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1816714 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rgolangh · 2020-05-11T15:31:46Z

/lgtm

rgolangh · 2020-05-11T15:32:16Z

/retest

openshift-bot · 2020-05-11T15:44:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-11T16:49:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-11T18:06:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-11T19:24:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-11T20:16:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-11T21:34:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-11T22:53:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T02:58:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T18:34:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T20:07:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T20:57:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T22:28:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T00:25:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T01:30:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T03:01:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T04:06:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T05:50:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

rgolangh · 2020-05-13T05:57:48Z

libvirt failures doesn't look related. In general it libvirt seem to fail a lot lately https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/?type=presubmit&job=*libvirt*
Can we please skip libvirt?

openshift-bot · 2020-05-13T06:55:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T08:00:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T09:18:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T10:49:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T11:54:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T13:25:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T14:43:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T16:14:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T17:45:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T19:16:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T19:30:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T20:34:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T20:47:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T22:18:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T23:22:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-05-14T00:38:44Z

@patrickdillon: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	`615242b`	link	`/test e2e-libvirt`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-05-14T00:53:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-05-14T01:31:01Z

@patrickdillon: All pull requests linked via external trackers have merged: openshift/installer#3569. Bugzilla bug 1820575 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1820575: Cherry-pick oVirt PR 3406 vNIC profiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rgolangh added 3 commits May 7, 2020 14:21

ovirt: a simpler function to get a connection to oVirt API

0abff89

Signed-off-by: Roy Golan <rgolan@redhat.com>

ovirt: Add platform validation

2a95a3d

Signed-off-by: Roy Golan <rgolan@redhat.com>

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 7, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 7, 2020

openshift-ci-robot requested review from jcpowermac and mtnbikenc May 7, 2020 18:28

sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020

patrickdillon mentioned this pull request May 8, 2020

Bug 1820575: add vnic profile to ovirt platform #3566

Closed

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 11, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 11, 2020

openshift-ci-robot assigned rgolangh May 11, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 13, 2020

openshift-merge-robot merged commit bab6d3e into openshift:release-4.4 May 14, 2020

Conversation

patrickdillon commented May 7, 2020

Uh oh!

openshift-ci-robot commented May 7, 2020

Uh oh!

patrickdillon commented May 7, 2020

Uh oh!

openshift-ci-robot commented May 7, 2020

Uh oh!

sdodson commented May 7, 2020

Uh oh!

patrickdillon commented May 7, 2020

Uh oh!

patrickdillon commented May 11, 2020

Uh oh!

openshift-ci-robot commented May 11, 2020

Uh oh!

rgolangh commented May 11, 2020

Uh oh!

rgolangh commented May 11, 2020

Uh oh!

openshift-bot commented May 11, 2020

Uh oh!

openshift-bot commented May 11, 2020

Uh oh!

openshift-bot commented May 11, 2020

Uh oh!

openshift-bot commented May 11, 2020

Uh oh!

openshift-bot commented May 11, 2020

Uh oh!

openshift-bot commented May 11, 2020

Uh oh!

openshift-bot commented May 11, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

rgolangh commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020