Skip to content

Bug 1832180: Exclude ovirt from syncing cloud-config sync#1717

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rgolangh:exclude-ovirt-from-cloud-config
May 6, 2020
Merged

Bug 1832180: Exclude ovirt from syncing cloud-config sync#1717
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rgolangh:exclude-ovirt-from-cloud-config

Conversation

@rgolangh
Copy link
Copy Markdown
Contributor

@rgolangh rgolangh commented May 6, 2020 •
edited
Loading

No description provided.

@runcom
Copy link
Copy Markdown
Member

runcom commented May 6, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2020
@runcom
Copy link
Copy Markdown
Member

runcom commented May 6, 2020

Pending BZ

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2020
@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented May 6, 2020

/test e2e-ovirt

@rgolangh rgolangh changed the title Exclude ovirt from syncing cloud-config sync Bug 1832180: Exclude ovirt from syncing cloud-config sync May 6, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 6, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 6, 2020

@rgolangh: This pull request references Bugzilla bug 1832180, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1832180: Exclude ovirt from syncing cloud-config sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 6, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 6, 2020

@rgolangh: This pull request references Bugzilla bug 1832180, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1832180: Exclude ovirt from syncing cloud-config sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented May 6, 2020

/test e2e-ovirt

1 similar comment
@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented May 6, 2020

/test e2e-ovirt

@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented May 6, 2020

/test e2e-metal-ipi

@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented May 6, 2020

we need to fix https://github.com/openshift/machine-config-operator/blob/master/pkg/controller/template/render.go#L508 as well.

@rgolangh
Exclude ovirt from syncing cloud-config sync
0b01e38 
Signed-off-by: Roy Golan <rgolan@redhat.com>
@rgolangh rgolangh force-pushed the exclude-ovirt-from-cloud-config branch from 64bc14e to 0b01e38 Compare May 6, 2020 11:37
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented May 6, 2020

/test e2e-ovirt

@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented May 6, 2020

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rgolangh, runcom, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented May 6, 2020

Valid bug exists
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2020
@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented May 6, 2020

/test e2e-metal-ipi

@rgolangh
Copy link
Copy Markdown
Contributor Author

rgolangh commented May 6, 2020

/test e2e-ovirt

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 6, 2020

@rgolangh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 0b01e38 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-metal-ipi 0b01e38 link /test e2e-metal-ipi
ci/prow/e2e-ovirt 0b01e38 link /test e2e-ovirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2733eec into openshift:master May 6, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 6, 2020

@rgolangh: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1717. Bugzilla bug 1832180 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1832180: Exclude ovirt from syncing cloud-config sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon patrickdillon mentioned this pull request May 7, 2020
Merged
@sinnykumari sinnykumari mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@runcom runcom

@sinnykumari sinnykumari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rgolangh @runcom @openshift-ci-robot @sinnykumari @openshift-bot @openshift-merge-robot