Skip to content

Bug 1934557: bump RHCOS image for LUKS fix#4745

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
miabbott:bz1934557_rhcos_bump
Mar 15, 2021
Merged

Bug 1934557: bump RHCOS image for LUKS fix#4745
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
miabbott:bz1934557_rhcos_bump

Conversation

@miabbott
Copy link
Copy Markdown
Member

@miabbott miabbott commented Mar 12, 2021 •
edited
Loading

This bumps the RHCOS boot image address the LUKS problem described in RHBZ#1934174

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 12, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 12, 2021

@miabbott: This pull request references Bugzilla bug 1934557, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

Bug 1934557: bump RHCOS image for LUKS fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott miabbott mentioned this pull request Mar 12, 2021
Closed
@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 12, 2021

ci/prow/e2e-aws-workers-rhel7 looks like it is permafailing

ci/prow/e2e-ovirt looks flaky

/test ci/prow/e2e-ovirt

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 12, 2021

@miabbott: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-proxy
  • /test e2e-aws-rhel8
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-azure-shared-vpc
  • /test e2e-azure-upi
  • /test e2e-crc
  • /test e2e-gcp
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi
  • /test e2e-gcp-upi-xpn
  • /test e2e-kubevirt
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-openstack
  • /test e2e-openstack-ipi
  • /test e2e-openstack-parallel
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-fmt
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

Use /test all to run the following jobs:

  • pull-ci-openshift-installer-master-e2e-aws
  • pull-ci-openshift-installer-master-e2e-aws-fips
  • pull-ci-openshift-installer-master-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-openstack-manifests
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

ci/prow/e2e-aws-workers-rhel7 looks like it is permafailing

ci/prow/e2e-ovirt looks flaky

/test ci/prow/e2e-ovirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 12, 2021

/test e2e-ovirt

staebler
staebler reviewed Mar 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@miabbott Can you assign someone on your team to review this for a lgtm?

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021
@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 12, 2021

/assign jlebon

@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 12, 2021 •
edited
Loading

e2e-aws-upgrade doesn't have a great track record of late. In this run, we see the following tests failing:

[sig-node] kubelet terminates kube-apiserver gracefully
[sig-node] pods should never transition back to pending

Both show up in Sippy as occurring frequently in the last 7 days, so seems unlikely related to this change.

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 12, 2021

This needs to bump the other arches too, no? (See #4422 (comment) and #4422 (comment) for instructions).

@staebler
Copy link
Copy Markdown
Contributor

staebler commented Mar 12, 2021

e2e-aws-upgrade doesn't have a great track record of late. In this run, we see the following tests failing:

[sig-node] kubelet terminates kube-apiserver gracefully
[sig-node] pods should never transition back to pending

Both show up in Sippy as occurring frequently in the last 7 days, so seems unlikely related to this change.

Yes, the allowable disruption time during upgrades was dropped to 0 in the past few weeks, making this job very flaky until the cause of disruptions is resolved. The failure is not necessarily a result of changes in this PR.

Mar 12 16:12:26.417: FAIL: API "openshift-api-available-reused-connections" was unreachable during disruption for at least 46s of 1h1m46s (1%)

@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 12, 2021

This needs to bump the other arches too, no? (See #4422 (comment) and #4422 (comment) for instructions).

Yeah, it should but the Power builds haven't been successful in some time.

I can update the PR to include s390x with the fix for the LUKS problem, but we'll be waiting on a successful Power build

@miabbott
Bug 1934557: bump RHCOS image for LUKS fix
348fd2f 
This bumps the RHCOS boot images to address the LUKS problem described
in RHBZ#1934174
@miabbott miabbott force-pushed the bz1934557_rhcos_bump branch from fe0d443 to 348fd2f Compare March 15, 2021 13:12
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 15, 2021

@miabbott: This pull request references Bugzilla bug 1934557, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

Bug 1934557: bump RHCOS image for LUKS fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 15, 2021

OK, we got a successful Power build over the weekend, so I've updated all arches to be at the latest build per this morning.

@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 15, 2021

/test e2e-ovirt

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 15, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021
@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 15, 2021

The failing tests look similar to the first run. Going to need some overrides here.

@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 15, 2021

/test e2e-aws
/test e2e-aws-fips

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 15, 2021 •
edited
Loading

@miabbott: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 348fd2f link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-fips 348fd2f link /test e2e-aws-fips
ci/prow/e2e-metal-ipi-ovn-ipv6 348fd2f link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented Mar 15, 2021 •
edited
Loading

e2e-aws looks like the actual test succeeded

2021/03/15 14:32:37 Pod e2e-aws-openshift-e2e-test succeeded after 28m45s

But gathering info about nodes/machines failed?

2021/03/15 14:33:27 Executing pod "e2e-aws-gather-aws-console" running image "pipeline:ocp-4.5-upi-installer"
2021/03/15 14:48:27 pod didn't start running within 15m0s: 
* Container sidecar is not ready with reason PodInitializing
* Container test is not ready with reason PodInitializing
Found 4 events for Pod e2e-aws-gather-aws-console:
* 0x : Successfully assigned ci-op-9vq1cqfl/e2e-aws-gather-aws-console to ip-10-0-128-195.ec2.internal
* 3x kubelet: Failed to create pod sandbox: rpc error: code = DeadlineExceeded desc = context deadline exceeded
* 1x multus: Add eth0 [10.130.17.191/23]
* 1x multus: Add eth0 [10.130.17.215/23]

All the other steps in that test were successful

@openshift-merge-robot openshift-merge-robot merged commit 0840970 into openshift:master Mar 15, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 15, 2021

@miabbott: All pull requests linked via external trackers have merged:

Bugzilla bug 1934557 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1934557: bump RHCOS image for LUKS fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

1 more reviewer

@staebler staebler staebler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jlebon jlebon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miabbott @openshift-ci-robot @jlebon @staebler @openshift-merge-robot